From patchwork Wed Dec 13 23:18:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 10111081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8216D60352 for ; Wed, 13 Dec 2017 23:20:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 740102970D for ; Wed, 13 Dec 2017 23:20:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 67F0729728; Wed, 13 Dec 2017 23:20:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEF972970D for ; Wed, 13 Dec 2017 23:20:49 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 6B807267979; Thu, 14 Dec 2017 00:19:12 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0AA81267988; Thu, 14 Dec 2017 00:19:09 +0100 (CET) Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by alsa0.perex.cz (Postfix) with ESMTP id 1FFFF267975 for ; Thu, 14 Dec 2017 00:19:01 +0100 (CET) Received: by mail-pg0-f68.google.com with SMTP id k15so2117620pgr.7 for ; Wed, 13 Dec 2017 15:19:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ScMbOmZuphBH8r2mYEujb0QgjB88MEiyCsLuiqrzQwE=; b=jdknJ9SX+5EDx0PcZ1kfRbUOzGTt4P0xtkI2+b/rM6tbyQcBtXV1VNtcfkQgotYd+M ai0jnH0KR8d+VJLnjIGnaRFYMVyOyBl8aHZirmFv+CdxWJ7eEDZwoFmro0zb5qF+z1N3 v46nR0NrtVMMLGDdUVEzsUpggeLag4t8h3BR48knpXYQbF6235Uqg8gGJiVUrrmWRLMG nk5HvIQb1pTx12FqneVe5O32Uvab1oe1btfCQrLilOT3ggamaB3svyCXyZBushvwd5fq nvA+5CO9W4jHM9e1NCm765gIUACevz8j5RTMINsypv1/Hgb/aayrenuRS+j3PQm3du5c BTqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ScMbOmZuphBH8r2mYEujb0QgjB88MEiyCsLuiqrzQwE=; b=j7DI3XvLsA2xyM0Z0WoWYARMadi19dWzPujz9ghq6PKzv4sOdldptb3poQjjnUrBaE b61Mwge/m16uy8mgJgnDmsQQvxb3eeVBTf5Uo1f+v1c15MujOTSiBko+YmmxdWSUB0q5 zpNZdenicgwmXw2gCiRhTeV/55LTvkX7NZ02KPj5a/KIp9hGWkBBR2tUpDEb/MR5YN1j xPHL0M+94l1Ya7ddKzvkB7pnnZ0eLZPkmEfWMPg+XmcrBjjoRskSNF+YlGFty5EMPGiK ZpeWWJ4wZ6crEzgwSYwfbE2e8GvCK+OlHbm5PhPK94dnNehsHQAYp3ioiGcpFe2mMEHT ysJw== X-Gm-Message-State: AKGB3mJfttTnXYGzR386Sa8pqLCEZkyBOANkHhwh9EVuqCRij3LsPWPl /JBsLTijiLLJgimo7kq9/2k= X-Google-Smtp-Source: ACJfBotDPd1afgujupUby/YA+ildFp1cWfyMEVjkT8+uQYnnt/TwSMaGwoL2PvuN5+sglmh443C/rQ== X-Received: by 10.98.194.150 with SMTP id w22mr7684426pfk.67.1513207140587; Wed, 13 Dec 2017 15:19:00 -0800 (PST) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id z2sm4232483pgu.17.2017.12.13.15.18.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Dec 2017 15:19:00 -0800 (PST) From: Nicolin Chen To: broonie@kernel.org Date: Wed, 13 Dec 2017 15:18:23 -0800 Message-Id: <1513207108-30430-7-git-send-email-nicoleotsuka@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1513207108-30430-1-git-send-email-nicoleotsuka@gmail.com> References: <1513207108-30430-1-git-send-email-nicoleotsuka@gmail.com> Cc: mail@maciej.szmigiero.name, timur@tabi.org, kernel@pengutronix.de, lgirdwood@gmail.com, alsa-devel@alsa-project.org, caleb@crome.org, linux-kernel@vger.kernel.org, arnaud.mouiche@invoxia.com, lukma@denx.de, fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org Subject: [alsa-devel] [PATCH v3 06/11] ASoC: fsl_ssi: Refine printk outputs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This patches unifies the error message in the "failed to xxxx" format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen Tested-by: Maciej S. Szmigiero Reviewed-by: Maciej S. Szmigiero --- sound/soc/fsl/fsl_ssi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index a3b9116..7b6aedd 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -701,7 +701,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, * never greater than 1/5 IPG clock rate */ if (freq * 5 > clk_get_rate(ssi->clk)) { - dev_err(cpu_dai->dev, "bitclk > ipgclk/5\n"); + dev_err(cpu_dai->dev, "bitclk > ipgclk / 5\n"); return -EINVAL; } @@ -873,7 +873,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ssi->dai_fmt = fmt; if (fsl_ssi_is_i2s_master(ssi) && IS_ERR(ssi->baudclk)) { - dev_err(dev, "baudclk is missing which is necessary for master mode\n"); + dev_err(dev, "missing baudclk for master mode\n"); return -EINVAL; } @@ -1289,7 +1289,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, ssi->clk = devm_clk_get(dev, NULL); if (IS_ERR(ssi->clk)) { ret = PTR_ERR(ssi->clk); - dev_err(dev, "could not get clock: %d\n", ret); + dev_err(dev, "failed to get clock: %d\n", ret); return ret; } @@ -1305,7 +1305,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, /* Do not error out for slave cases that live without a baud clock */ ssi->baudclk = devm_clk_get(dev, "baud"); if (IS_ERR(ssi->baudclk)) - dev_dbg(dev, "could not get baud clock: %ld\n", + dev_dbg(dev, "failed to get baud clock: %ld\n", PTR_ERR(ssi->baudclk)); ssi->dma_params_tx.maxburst = ssi->dma_maxburst; @@ -1426,7 +1426,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ®config); } if (IS_ERR(ssi->regs)) { - dev_err(dev, "Failed to init register map\n"); + dev_err(dev, "failed to init register map\n"); return PTR_ERR(ssi->regs); } @@ -1485,7 +1485,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) mutex_init(&ssi->ac97_reg_lock); ret = snd_soc_set_ac97_ops_of_reset(&fsl_ssi_ac97_ops, pdev); if (ret) { - dev_err(dev, "could not set AC'97 ops\n"); + dev_err(dev, "failed to set AC'97 ops\n"); goto error_ac97_ops; } } @@ -1501,7 +1501,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = devm_request_irq(dev, ssi->irq, fsl_ssi_isr, 0, dev_name(dev), ssi); if (ret < 0) { - dev_err(dev, "could not claim irq %u\n", ssi->irq); + dev_err(dev, "failed to claim irq %u\n", ssi->irq); goto error_asoc_register; } } @@ -1543,7 +1543,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = of_property_read_u32(np, "cell-index", &ssi_idx); if (ret) { - dev_err(dev, "cannot get SSI index property\n"); + dev_err(dev, "failed to get SSI index property\n"); goto error_sound_card; }