From patchwork Mon Dec 18 02:52:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 10118179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9188560327 for ; Mon, 18 Dec 2017 02:55:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 786B529028 for ; Mon, 18 Dec 2017 02:55:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D41B29046; Mon, 18 Dec 2017 02:55:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0E1E29028 for ; Mon, 18 Dec 2017 02:54:59 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8991B267210; Mon, 18 Dec 2017 03:53:37 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7637D2671DB; Mon, 18 Dec 2017 03:53:34 +0100 (CET) Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by alsa0.perex.cz (Postfix) with ESMTP id 7FC482671A6 for ; Mon, 18 Dec 2017 03:53:29 +0100 (CET) Received: by mail-pl0-f67.google.com with SMTP id s3so3992617plp.4 for ; Sun, 17 Dec 2017 18:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4GiXcLHb0nwl8n/6vO//M953nlGJA3z2SbIhH7tynso=; b=OiJwOeJ7peKVkFFwAij0POt0XR77DnMwEq5ZMxq772McqWFhBJFIL2AiAfynl4W4NF hUXH4YJK9PuxdTSmIpEmGd+hbechTeaYaGR3+hkesK9XR23QRvctiinV5jY8AF9ci3vz R0iPEjVUuJj37sz5Tl0q4ZAknE35VQaaWxmV6QWyMYkPcMe4B2uDT4TeWMwT0lD21iDt o5+eYIv73CE0DOniXj4XOl32oMDELM+oZpY5c40pPB/zDE+ITB3JUDqwyAOYWwpZ5MFl IYgZ/1vwuz50/Y2JNsPWCe18Q5w9RlEuHkeHMr94orOihorUD4KDIFtx44rYsVyXXlgB dsow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4GiXcLHb0nwl8n/6vO//M953nlGJA3z2SbIhH7tynso=; b=iXk8RQYBFh3JVVmhIZwofjbxagxq4ymKft6fYFlSdSjbZYNYE+QLz1hIY8OY0imZYD 6FGQFGH/ATsoX6NNOzmtrxHs9vxvy0C1hb7e24wdbYSq6CwkYq3h99koy8PTUdnc06n/ /rS8wnfMi59sx7kMzqh/3GXFC6wXCr/vRT/tbNNgfiVuZpHyqi217fDZK0vGB2b+j5pU E7QWw/ChwXH4TtWmlZftQMcmlVwplKANL2fjQN7z5u+d0LaEKWb0KpWQhuiUOpcI75ag zLFDG3GYMKsPbkmWJpjUNfHcspS9P/bcbdJFc0EjcWCe5gQ0nJS7ycjHR1ZmEvu5AMeM 3PuA== X-Gm-Message-State: AKGB3mImbWiVOJVBAhGKyy9r+IHlsqZQiYQy+E8Rb+5LOOq9VV/Of7Nd aPu8SVNEmYwMNkRGTzjR0OQ= X-Google-Smtp-Source: ACJfBouVj60ese+ARuL/+InEEywZzpaS1CgqNXIORm20D/2vVwSrsA9mZbevr4D5WIvM5lp+vBBD3g== X-Received: by 10.159.206.195 with SMTP id x3mr20966472plo.338.1513565608593; Sun, 17 Dec 2017 18:53:28 -0800 (PST) Received: from Asurada-CZ80.localdomain (c-73-231-2-134.hsd1.ca.comcast.net. [73.231.2.134]) by smtp.gmail.com with ESMTPSA id x6sm21943630pfx.29.2017.12.17.18.53.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 17 Dec 2017 18:53:28 -0800 (PST) From: Nicolin Chen To: timur@tabi.org, broonie@kernel.org Date: Sun, 17 Dec 2017 18:52:05 -0800 Message-Id: <1513565530-33957-7-git-send-email-nicoleotsuka@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513565530-33957-1-git-send-email-nicoleotsuka@gmail.com> References: <1513565530-33957-1-git-send-email-nicoleotsuka@gmail.com> Cc: mail@maciej.szmigiero.name, kernel@pengutronix.de, lgirdwood@gmail.com, alsa-devel@alsa-project.org, caleb@crome.org, linux-kernel@vger.kernel.org, arnaud.mouiche@invoxia.com, lukma@denx.de, fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org Subject: [alsa-devel] [PATCH v4 06/11] ASoC: fsl_ssi: Refine printk outputs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This patches unifies the error message in the "failed to xxxx" format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen Tested-by: Maciej S. Szmigiero Reviewed-by: Maciej S. Szmigiero --- sound/soc/fsl/fsl_ssi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index ed9ac75..eb9ac84 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -716,7 +716,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, * never greater than 1/5 IPG clock rate */ if (freq * 5 > clk_get_rate(ssi->clk)) { - dev_err(cpu_dai->dev, "bitclk > ipgclk/5\n"); + dev_err(cpu_dai->dev, "bitclk > ipgclk / 5\n"); return -EINVAL; } @@ -888,7 +888,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ssi->dai_fmt = fmt; if (fsl_ssi_is_i2s_master(ssi) && IS_ERR(ssi->baudclk)) { - dev_err(dev, "baudclk is missing which is necessary for master mode\n"); + dev_err(dev, "missing baudclk for master mode\n"); return -EINVAL; } @@ -1307,7 +1307,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, ssi->clk = devm_clk_get(dev, NULL); if (IS_ERR(ssi->clk)) { ret = PTR_ERR(ssi->clk); - dev_err(dev, "could not get clock: %d\n", ret); + dev_err(dev, "failed to get clock: %d\n", ret); return ret; } @@ -1323,7 +1323,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, /* Do not error out for slave cases that live without a baud clock */ ssi->baudclk = devm_clk_get(dev, "baud"); if (IS_ERR(ssi->baudclk)) - dev_dbg(dev, "could not get baud clock: %ld\n", + dev_dbg(dev, "failed to get baud clock: %ld\n", PTR_ERR(ssi->baudclk)); ssi->dma_params_tx.maxburst = ssi->dma_maxburst; @@ -1447,7 +1447,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ®config); } if (IS_ERR(ssi->regs)) { - dev_err(dev, "Failed to init register map\n"); + dev_err(dev, "failed to init register map\n"); return PTR_ERR(ssi->regs); } @@ -1513,7 +1513,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) mutex_init(&ssi->ac97_reg_lock); ret = snd_soc_set_ac97_ops_of_reset(&fsl_ssi_ac97_ops, pdev); if (ret) { - dev_err(dev, "could not set AC'97 ops\n"); + dev_err(dev, "failed to set AC'97 ops\n"); goto error_ac97_ops; } } @@ -1529,7 +1529,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = devm_request_irq(dev, ssi->irq, fsl_ssi_isr, 0, dev_name(dev), ssi); if (ret < 0) { - dev_err(dev, "could not claim irq %u\n", ssi->irq); + dev_err(dev, "failed to claim irq %u\n", ssi->irq); goto error_asoc_register; } } @@ -1571,7 +1571,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = of_property_read_u32(np, "cell-index", &ssi_idx); if (ret) { - dev_err(dev, "cannot get SSI index property\n"); + dev_err(dev, "failed to get SSI index property\n"); goto error_sound_card; }