diff mbox

[1/2] ASoC: wm9712: Use empty struct initializer

Message ID 1518550536-16279-1-git-send-email-festevam@gmail.com (mailing list archive)
State Accepted
Commit 60edb2006030894a4e45c84b04369cb70939d695
Headers show

Commit Message

Fabio Estevam Feb. 13, 2018, 7:35 p.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

{ 0 } only clears the first member of the structure.

The first member of the snd_soc_dapm_update struct is pointer,
so wrting 0 to a pointer results in the following sparse warning:

sound/soc/codecs/wm9712.c:229:47: warning: Using plain integer as NULL pointer

Use the empty struct initializer that clears all the struct members
and fixes the sparse warning.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 sound/soc/codecs/wm9712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Charles Keepax Feb. 14, 2018, 9:33 a.m. UTC | #1 
On Tue, Feb 13, 2018 at 05:35:35PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> { 0 } only clears the first member of the structure.
> 
> The first member of the snd_soc_dapm_update struct is pointer,
> so wrting 0 to a pointer results in the following sparse warning:
> 
> sound/soc/codecs/wm9712.c:229:47: warning: Using plain integer as NULL pointer
> 
> Use the empty struct initializer that clears all the struct members
> and fixes the sparse warning.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
diff mbox

Patch

diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
index 7aeeeec..953d94d 100644
--- a/sound/soc/codecs/wm9712.c
+++ b/sound/soc/codecs/wm9712.c
@@ -226,7 +226,7 @@  static int wm9712_hp_mixer_put(struct snd_kcontrol *kcontrol,
 	struct soc_mixer_control *mc =
 		(struct soc_mixer_control *)kcontrol->private_value;
 	unsigned int mixer, mask, shift, old;
-	struct snd_soc_dapm_update update = { 0 };
+	struct snd_soc_dapm_update update = {};
 	bool change;
 
 	mixer = mc->shift >> 8;