| Message ID | 1520845883-24062-1-git-send-email-akshu.agrawal@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f155181d23608acd3fb46d0d6b1507b68ffa436b |
| Headers | show |
On Mon, Mar 12, 2018 at 02:41:22PM +0530, Akshu Agrawal wrote: > BT I2S is a bi-directional dai, we will use the same > cpu dai for playback and capture. > > TEST=Build, apply grunt_mixer_settings: > iotools mmio_write32 0xfed80e40 0x040c40c0 > iotools mmio_write32 0xfed80e28 0x10000 > aplay -D hw:0,0 -vv <file> > arecord -D hw:0,0 -f dat -d 5 -vv <file> These reproduction instructions don't make much sense outside of your test environment (how is anyone supposed to know what grunt_mixer_settings is?). I'm also rather worried about the random magic numbers you're using with this iowrite tool - what do they do? It sounds like this driver might not work at all without some missing bit...
On 3/12/2018 10:31 PM, Mark Brown wrote: > On Mon, Mar 12, 2018 at 02:41:22PM +0530, Akshu Agrawal wrote: >> BT I2S is a bi-directional dai, we will use the same >> cpu dai for playback and capture. >> >> TEST=Build, apply grunt_mixer_settings: >> iotools mmio_write32 0xfed80e40 0x040c40c0 >> iotools mmio_write32 0xfed80e28 0x10000 >> aplay -D hw:0,0 -vv <file> >> arecord -D hw:0,0 -f dat -d 5 -vv <file> > > These reproduction instructions don't make much sense outside of your > test environment (how is anyone supposed to know what > grunt_mixer_settings is?). I'm also rather worried about the random > magic numbers you're using with this iowrite tool - what do they do? It > sounds like this driver might not work at all without some missing > bit... > write instructions are actually setting up the oscillator. These are being done in coreboot and patch is being pushed for same. I will remove these noise from TEST field and submit again.
diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index bbe0f10..d07c2a1 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -124,8 +124,8 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) static struct snd_soc_dai_link cz_dai_7219_98357[] = { { - .name = "amd-da7219-play", - .stream_name = "Playback", + .name = "amd-da7219-play-cap", + .stream_name = "Playback and Capture", .platform_name = "acp_audio_dma.0.auto", .cpu_dai_name = "designware-i2s.3.auto", .codec_dai_name = "da7219-hifi", @@ -134,16 +134,6 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) | SND_SOC_DAIFMT_CBM_CFM, .init = cz_da7219_init, .dpcm_playback = 1, - }, - { - .name = "amd-da7219-cap", - .stream_name = "Capture", - .platform_name = "acp_audio_dma.0.auto", - .cpu_dai_name = "designware-i2s.4.auto", - .codec_dai_name = "da7219-hifi", - .codec_name = "i2c-DLGS7219:00", - .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF - | SND_SOC_DAIFMT_CBM_CFM, .dpcm_capture = 1, .ops = &cz_da7219_cap_ops, },
BT I2S is a bi-directional dai, we will use the same cpu dai for playback and capture. TEST=Build, apply grunt_mixer_settings: iotools mmio_write32 0xfed80e40 0x040c40c0 iotools mmio_write32 0xfed80e28 0x10000 aplay -D hw:0,0 -vv <file> arecord -D hw:0,0 -f dat -d 5 -vv <file> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)