ASoC: amd: Missing Initialization of IRQFLAGS

Commit Message

RAVULAPATI, VISHNU VARDHAN RAO Sept. 27, 2019, 12:04 a.m. UTC

Fix for missing initialization of IRQFLAGS in
ACP-PCI driver and Missing Macro of ACP3x_DEVS.

Follow up to IDb33df346

Signed-off-by: Ravulapati Vishnu vardhan rao <[e-mail]>
---
 sound/soc/amd/raven/pci-acp3x.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Mark Brown Sept. 26, 2019, 3:19 p.m. UTC | #1

On Fri, Sep 27, 2019 at 05:34:47AM +0530, Ravulapati Vishnu vardhan rao wrote:
> Fix for missing initialization of IRQFLAGS in
> ACP-PCI driver and Missing Macro of ACP3x_DEVS.
> 
> Follow up to IDb33df346

What is "IDb33df346"?

Patch

diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
index 627798a..3887ea0 100644
--- a/sound/soc/amd/raven/pci-acp3x.c
+++ b/sound/soc/amd/raven/pci-acp3x.c
@@ -219,7 +219,7 @@  static int snd_acp3x_probe(struct pci_dev *pci,
 				sizeof(struct resource) * 4,
 						GFP_KERNEL);
 		adata->cell = devm_kzalloc(&pci->dev,
-				sizeof(struct mfd_cell) * 3,
+				sizeof(struct mfd_cell) * ACP3x_DEVS,
 						GFP_KERNEL);
 		if (!adata->cell) {
 			ret = -ENOMEM;
@@ -260,6 +260,7 @@  static int snd_acp3x_probe(struct pci_dev *pci,
 		adata->res[3].flags	= IORESOURCE_IRQ;
 		adata->res[3].start	= pci->irq;
 		adata->res[3].end	= adata->res[3].start;
+		irqflags		= 0;
 
 		adata->acp3x_audio_mode	= ACP3x_I2S_MODE;
 
@@ -282,8 +283,9 @@  static int snd_acp3x_probe(struct pci_dev *pci,
 		adata->cell[2].platform_data	= &i2s_pdata[1];
 		adata->cell[2].pdata_size	=
 				sizeof(struct i2s_platform_data);
-		r = mfd_add_hotplug_devices(adata->parent, adata->cell,	3);
-		for (i = 0; i < 3 ; i++)
+		r = mfd_add_hotplug_devices(adata->parent, adata->cell,
+								ACP3x_DEVS);
+		for (i = 0; i < ACP3x_DEVS ; i++)
 			dev = get_mfd_cell_dev(adata->cell[i].name, i);
 		break;