| Message ID | 1587468525-27514-1-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1e060a453c8604311fb45ae2f84f67ed673329b4 |
| Headers | show |
| Series | ASoC: wm8960: Fix wrong clock after suspend & resume | expand |
On Tue, Apr 21, 2020 at 07:28:45PM +0800, Shengjiu Wang wrote: > After suspend & resume, wm8960_hw_params may be called when > bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking > is not called. But if sample rate is changed at that time, then > the output clock rate will be not correct. > > So judgement of bias_level is SND_SOC_BIAS_ON in wm8960_hw_params > is not necessary and it causes above issue. > > Fixes: 3176bf2d7ccd ("ASoC: wm8960: update pll and clock setting function") > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Tue, 21 Apr 2020 19:28:45 +0800, Shengjiu Wang wrote: > After suspend & resume, wm8960_hw_params may be called when > bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking > is not called. But if sample rate is changed at that time, then > the output clock rate will be not correct. > > So judgement of bias_level is SND_SOC_BIAS_ON in wm8960_hw_params > is not necessary and it causes above issue. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7 Thanks! [1/1] ASoC: wm8960: Fix wrong clock after suspend & resume commit: 1e060a453c8604311fb45ae2f84f67ed673329b4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 55112c1bba5e..6cf0f6612bda 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -860,8 +860,7 @@ static int wm8960_hw_params(struct snd_pcm_substream *substream, wm8960->is_stream_in_use[tx] = true; - if (snd_soc_component_get_bias_level(component) == SND_SOC_BIAS_ON && - !wm8960->is_stream_in_use[!tx]) + if (!wm8960->is_stream_in_use[!tx]) return wm8960_configure_clocking(component); return 0;
After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock rate will be not correct. So judgement of bias_level is SND_SOC_BIAS_ON in wm8960_hw_params is not necessary and it causes above issue. Fixes: 3176bf2d7ccd ("ASoC: wm8960: update pll and clock setting function") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- sound/soc/codecs/wm8960.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)