| Message ID | 1616777074-5151-2-git-send-email-Vijendar.Mukunda@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d463cead11ace05c81de31a0fb9c2507c5c1d0a2 |
| Headers | show |
| Series | [RESEND,1/2] ASoC: amd: update spdx license for acp machine driver | expand |
On Fri, Mar 26, 2021 at 5:44 PM Vijendar Mukunda <Vijendar.Mukunda@amd.com> wrote: > > Fix ACPI dependency kernel warning produced by powerpc > allyesconfig. > > sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: > 'cz_rt5682_card' defined but not used [-Wunused-variable] > > sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card' > defined but not used [-Wunused-variable] I would suggest simply dropping the unnecessary #ifdef and ACPI_PTR() guard. It might be helpful to hide the Kconfig submenu under 'depends on X86 || COMPILE_TEST'. Arnd
On 3/26/21 10:14 PM, Arnd Bergmann wrote: > On Fri, Mar 26, 2021 at 5:44 PM Vijendar Mukunda > <Vijendar.Mukunda@amd.com> wrote: >> >> Fix ACPI dependency kernel warning produced by powerpc >> allyesconfig. >> >> sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: >> 'cz_rt5682_card' defined but not used [-Wunused-variable] >> >> sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card' >> defined but not used [-Wunused-variable] > > I would suggest simply dropping the unnecessary #ifdef and > ACPI_PTR() guard. > > It might be helpful to hide the Kconfig submenu under > 'depends on X86 || COMPILE_TEST'. > > Arnd > Will drop the unnecessary safegaurd and will upload the new version.
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index 43f5d29..256c192 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -11,7 +11,7 @@ config SND_SOC_AMD_CZ_DA7219MX98357_MACH select SND_SOC_MAX98357A select SND_SOC_ADAU7002 select REGULATOR - depends on SND_SOC_AMD_ACP && I2C && GPIOLIB + depends on SND_SOC_AMD_ACP && I2C && GPIOLIB && ACPI help This option enables machine driver for DA7219, RT5682 and MAX9835.
Fix ACPI dependency kernel warning produced by powerpc allyesconfig. sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: 'cz_rt5682_card' defined but not used [-Wunused-variable] sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card' defined but not used [-Wunused-variable] Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com> --- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)