Message ID | 1620298735-31708-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 1d122dd3b168f55e2e29982cff80f1c15f66ef26 |
Headers | show |
Series | ASoC: rt286: Remove redundant assignment to d_len_code | expand |
On Thu, 6 May 2021 18:58:55 +0800, Jiapeng Chong wrote: > Variable d_len_code is set to zero, but this value is never read as > it is overwritten or not used later on, hence it is a redundant > assignment and can be removed. > > Clean up the following clang-analyzer warning: > > sound/soc/codecs/rt286.c:728:2: warning: Value stored to 'd_len_code' is > never read [clang-analyzer-deadcode.DeadStores]. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: rt286: Remove redundant assignment to d_len_code commit: 1d122dd3b168f55e2e29982cff80f1c15f66ef26 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c index 802f485..caa7208 100644 --- a/sound/soc/codecs/rt286.c +++ b/sound/soc/codecs/rt286.c @@ -725,7 +725,6 @@ static int rt286_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - d_len_code = 0; switch (params_width(params)) { /* bit 6:4 Bits per Sample */ case 16:
Variable d_len_code is set to zero, but this value is never read as it is overwritten or not used later on, hence it is a redundant assignment and can be removed. Clean up the following clang-analyzer warning: sound/soc/codecs/rt286.c:728:2: warning: Value stored to 'd_len_code' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- sound/soc/codecs/rt286.c | 1 - 1 file changed, 1 deletion(-)