| Message ID | 1674108674-8392-2-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Update lpass dt-bindings | expand |
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote: > Upadte clock name from core to macro in lpass-va-macro node Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > to make it compatible with existing driver and device tree node. > > Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec") > Drop blank line, > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Tested-by: Ratna Deepthi Kudaravalli <quic_rkudarv@quicinc.com> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> https://lore.kernel.org/all/838e7657-817c-e5bd-5a45-d852560c7fe1@linaro.org/ > --- > Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > index 26f0343..e468adb 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > @@ -36,7 +36,7 @@ properties: > oneOf: > - items: #for ADSP based platforms > - const: mclk > - - const: core > + - const: macro > - const: dcodec > - items: #for ADSP bypass based platforms > - const: mclk Best regards, Krzysztof
On Thu, 19 Jan 2023 11:41:12 +0530, Srinivasa Rao Mandadapu wrote: > Upadte clock name from core to macro in lpass-va-macro node > to make it compatible with existing driver and device tree node. > > Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec") > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Tested-by: Ratna Deepthi Kudaravalli <quic_rkudarv@quicinc.com> > --- > Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.example.dtb: codec@3370000: clock-names: 'oneOf' conditional failed, one must be fixed: ['mclk', 'core', 'dcodec'] is too long 'macro' was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.example.dtb: codec@3370000: Unevaluated properties are not allowed ('clock-names' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1674108674-8392-2-git-send-email-quic_srivasam@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml index 26f0343..e468adb 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml @@ -36,7 +36,7 @@ properties: oneOf: - items: #for ADSP based platforms - const: mclk - - const: core + - const: macro - const: dcodec - items: #for ADSP bypass based platforms - const: mclk
Upadte clock name from core to macro in lpass-va-macro node to make it compatible with existing driver and device tree node. Fixes: 67d99b23c881 ("ASoC: qcom: dt-bindings: add bindings for lpass va macro codec") Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Tested-by: Ratna Deepthi Kudaravalli <quic_rkudarv@quicinc.com> --- Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)