From patchwork Thu Apr 23 19:12:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriele Mazzotta X-Patchwork-Id: 6264711 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 37F6EBF4A6 for ; Thu, 23 Apr 2015 19:13:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5A09F20394 for ; Thu, 23 Apr 2015 19:13:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id B397520396 for ; Thu, 23 Apr 2015 19:13:10 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 61C10260417; Thu, 23 Apr 2015 21:13:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 7CB5B2602AD; Thu, 23 Apr 2015 21:13:01 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4A6BA260309; Thu, 23 Apr 2015 21:13:00 +0200 (CEST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by alsa0.perex.cz (Postfix) with ESMTP id 324A72602AD for ; Thu, 23 Apr 2015 21:12:53 +0200 (CEST) Received: by wicmx19 with SMTP id mx19so19397288wic.1 for ; Thu, 23 Apr 2015 12:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; bh=DR0LVof09tfCPkiP2tpHRYem747287UJ+rlMUV1GgVc=; b=UkDH4+f4eOZKHymNARRcw14Uv+A7esO68y9fxvUv7mPC4CWQGCPB7aCHgxvPWbdWh8 uyRPeEAzoTg9qMgSVH1cp/xbe7sek4iFg5DFHfUmwf/B/Xc+nPB0A82OgeWqfm5oLa6S r+vzXfn/Hdd+/u2D8lFFkVh9Z8DJVirDSdB99XXnbuvFK8jIHOlkzgVfKE9nNQjgOeUZ ViUiYHpdjHTSRjM6OLQSDQO3V5Z6jHhd8KzGMnyTTIonIcAvSzxjErdx3oOq4H8PWc++ rHg84vVbZZYn+xKXUDt3izXoeZATKF7w8nAjrSoPdjWNdlpobAMMn5fi9XxbdpAUhUqH a2jQ== X-Received: by 10.194.92.137 with SMTP id cm9mr8452591wjb.133.1429816372885; Thu, 23 Apr 2015 12:12:52 -0700 (PDT) Received: from hostprova (2-235-140-64.ip228.fastwebnet.it. [2.235.140.64]) by mx.google.com with ESMTPSA id ch6sm13482487wjc.3.2015.04.23.12.12.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2015 12:12:52 -0700 (PDT) From: Gabriele Mazzotta To: alsa-devel@alsa-project.org Date: Thu, 23 Apr 2015 21:12:50 +0200 Message-ID: <1799826.AYplPzq8AK@xps13> In-Reply-To: <23057263.IjMh4t6SYF@xps13> References: <23057263.IjMh4t6SYF@xps13> MIME-Version: 1.0 Cc: tiwai@suse.de, superquad.vortex2@gmail.com Subject: Re: [alsa-devel] Pop noise on startup when headphones are plugged in (Dell XPS13 9333) X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Sunday 19 April 2015 19:26:58 Gabriele Mazzotta wrote: > Hi, > > I've recently found that commit a551d91473 ("ALSA: hda - Use regmap for > command verb caches, too") is somehow causing a pop noise on startup > when headphones are plugged in, but I couldn't figure out the exact > cause. Was this observed on other systems (mine is a Dell XPS13 9333, > Realtek ALC3661)? Does anyone have any idea of what the cause might be? Hi, I don't know why a551d91473 caused the issue, but I found the real cause of problem. On init, create_input_ctls() sets the vref of nid 0x19 to 80 (as returned by snd_hda_get_default_vref()), but it should be set to HIZ. This is not so different from the issue addressed by f38663ab5c ("ALSA: hda - Set internal mic as default input source on Dell XPS 13 9333"). I made a patch to prevent this from happening. Setting the vref is not necessary since alc_update_headset_mode() will take care of it. Should I maybe add a new flag instead of using suppress_hp_mic_detect? --- sound/pci/hda/hda_generic.c | 3 ++- sound/pci/hda/patch_realtek.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 3d2597b..adf84ab 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -3257,7 +3257,8 @@ static int create_input_ctls(struct hda_codec *codec) continue; val = PIN_IN; - if (cfg->inputs[i].type == AUTO_PIN_MIC) + if (cfg->inputs[i].type == AUTO_PIN_MIC && + !spec->suppress_hp_mic_detect) val |= snd_hda_get_default_vref(codec, pin); if (pin != spec->hp_mic_pin) set_pin_target(codec, pin, val, false); diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 231d0e4..3d854e7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4062,6 +4062,7 @@ static void alc_fixup_headset_mode(struct hda_codec *codec, switch (action) { case HDA_FIXUP_ACT_PRE_PROBE: + spec->gen.suppress_hp_mic_detect = 1; spec->parse_flags |= HDA_PINCFG_HEADSET_MIC | HDA_PINCFG_HEADPHONE_MIC; break; case HDA_FIXUP_ACT_PROBE: