From patchwork Wed Feb 26 14:29:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 3724331 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B258F9F35F for ; Wed, 26 Feb 2014 14:30:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DB98B2017B for ; Wed, 26 Feb 2014 14:30:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id A5B0920170 for ; Wed, 26 Feb 2014 14:30:02 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 92E2A265752; Wed, 26 Feb 2014 15:29:59 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 4494E2656B0; Wed, 26 Feb 2014 15:29:49 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id E6D212656E9; Wed, 26 Feb 2014 15:29:47 +0100 (CET) Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 498BF2656A6 for ; Wed, 26 Feb 2014 15:29:41 +0100 (CET) Received: from opensource.wolfsonmicro.com (opensource [80.75.67.52]) by opensource.wolfsonmicro.com (Postfix) with ESMTPSA id 828583B40EE; Wed, 26 Feb 2014 14:29:40 +0000 (GMT) Date: Wed, 26 Feb 2014 14:29:28 +0000 From: Richard Fitzgerald To: vinod.koul@intel.com Message-ID: <20140226142829.GB2002@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Cc: ckeepax@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, elaurent@google.com Subject: [alsa-devel] [TINYCOMPRESS][PATCH 1/1] compress: no need to set metadata before calling next_track X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The metadata is mainly for MP3 gapless playback, since the MP3 audio stream does not contain enough information to enable gapless. Other audio formats do not necessarily require any additional metadata so we should allow next_track to be called without any metadata. Signed-off-by: Zhao Weijia Signed-off-by: Richard Fitzgerald --- compress.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/compress.c b/compress.c index 15dfdb7..0c9ecd2 100644 --- a/compress.c +++ b/compress.c @@ -534,8 +534,6 @@ int compress_next_track(struct compress *compress) if (!is_compress_running(compress)) return oops(compress, ENODEV, "device not ready"); - if (!compress->gapless_metadata) - return oops(compress, EPERM, "metadata not set"); if (ioctl(compress->fd, SNDRV_COMPRESS_NEXT_TRACK)) return oops(compress, errno, "cannot set next track\n"); compress->next_track = 1;