From patchwork Mon Mar 9 18:18:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5970571 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CD1F99F380 for ; Mon, 9 Mar 2015 18:19:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D71D202B8 for ; Mon, 9 Mar 2015 18:19:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id E316E201FE for ; Mon, 9 Mar 2015 18:19:19 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1AE6A261483; Mon, 9 Mar 2015 19:19:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 87F32260824; Mon, 9 Mar 2015 19:18:41 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7182C2612AE; Mon, 9 Mar 2015 19:18:40 +0100 (CET) Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by alsa0.perex.cz (Postfix) with ESMTP id 45F512607FF for ; Mon, 9 Mar 2015 19:18:20 +0100 (CET) Received: by igkb16 with SMTP id b16so23505990igk.1 for ; Mon, 09 Mar 2015 11:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=K1DTCVGooBhwnLhv1+/ohD6arUFJj359XBq4RE1lDdI=; b=O0eA/1uMJCRDzoc3gEMNlLihuSNqCkHkdK+4WkSDmqAyj3c2s4XGu3JvymhCEIjt2z Ye2Byew6eZa3rnTd6CNmeaJFKpwTiWl4Rlanq0+6LsRZLkh5/i4mfJQy1Fu83Fuy2qjd OCbtxYI9i9QsawysrxB/Al4KnpP2wdTIgXdUxFzg7rUBIJrUfZ1F5hiiVmXebE7Anras M2FpKznfXZbQ1MrEQ0vgIIyhp2+81Y+nhB9wgxtr9yhWaxW0nKq515wAckvcVOwDYoSb LoWNnGoAGJAIRuSAn3E8IAvuNH478Crnb/t3BKPgL0JA+8sScB0SfZ2aAxSTLr2tNjk6 DeRA== X-Received: by 10.50.107.7 with SMTP id gy7mr49831453igb.49.1425925099422; Mon, 09 Mar 2015 11:18:19 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:e89d:fc51:1f84:5b7a]) by mx.google.com with ESMTPSA id l11sm12556992ioe.31.2015.03.09.11.18.16 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 09 Mar 2015 11:18:18 -0700 (PDT) Date: Mon, 9 Mar 2015 11:18:14 -0700 From: Dmitry Torokhov To: Mark Brown Message-ID: <20150309181814.GA27608@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH] ASoC: tlv320aic23: remove incorrect __exit markups X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- sound/soc/codecs/tlv320aic23-i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tlv320aic23-i2c.c b/sound/soc/codecs/tlv320aic23-i2c.c index f137019..78a94af 100644 --- a/sound/soc/codecs/tlv320aic23-i2c.c +++ b/sound/soc/codecs/tlv320aic23-i2c.c @@ -31,7 +31,7 @@ static int tlv320aic23_i2c_probe(struct i2c_client *i2c, return tlv320aic23_probe(&i2c->dev, regmap); } -static int __exit tlv320aic23_i2c_remove(struct i2c_client *i2c) +static int tlv320aic23_i2c_remove(struct i2c_client *i2c) { snd_soc_unregister_codec(&i2c->dev); return 0; @@ -56,7 +56,7 @@ static struct i2c_driver tlv320aic23_i2c_driver = { .of_match_table = of_match_ptr(tlv320aic23_of_match), }, .probe = tlv320aic23_i2c_probe, - .remove = __exit_p(tlv320aic23_i2c_remove), + .remove = tlv320aic23_i2c_remove, .id_table = tlv320aic23_id, };