| Message ID | 20150520074035.GB18278@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2d52d172398249f523b24cff9b84aee4e7b8e1b6 |
| Headers | show |
On Wed, May 20, 2015 at 10:40:35AM +0300, Dan Carpenter wrote: > Static checkers complain that "ret" is always zero so the conditions are > never true. > > The intention here was clearly to check for errors from > wm8741_set_pdata(). Although, since wm8741_set_pdata() never returns > errors, it doesn't affect runtime. > > Fixes: c354b54cfdf6 ('ASoC: wm8741: Add differential mono mode support') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
On Wed, May 20, 2015 at 10:40:35AM +0300, Dan Carpenter wrote: > Static checkers complain that "ret" is always zero so the conditions are > never true. Applied, thanks.
diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c index c065ea1..09ff01f 100644 --- a/sound/soc/codecs/wm8741.c +++ b/sound/soc/codecs/wm8741.c @@ -613,7 +613,7 @@ static int wm8741_i2c_probe(struct i2c_client *i2c, return ret; } - wm8741_set_pdata(&i2c->dev, wm8741); + ret = wm8741_set_pdata(&i2c->dev, wm8741); if (ret != 0) { dev_err(&i2c->dev, "Failed to set pdata: %d\n", ret); return ret; @@ -679,7 +679,7 @@ static int wm8741_spi_probe(struct spi_device *spi) return ret; } - wm8741_set_pdata(&spi->dev, wm8741); + ret = wm8741_set_pdata(&spi->dev, wm8741); if (ret != 0) { dev_err(&spi->dev, "Failed to set pdata: %d\n", ret); return ret;
Static checkers complain that "ret" is always zero so the conditions are never true. The intention here was clearly to check for errors from wm8741_set_pdata(). Although, since wm8741_set_pdata() never returns errors, it doesn't affect runtime. Fixes: c354b54cfdf6 ('ASoC: wm8741: Add differential mono mode support') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>