From patchwork Thu Jun 11 13:14:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 6611441 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B4E9A9F326 for ; Mon, 15 Jun 2015 18:54:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E8EA120798 for ; Mon, 15 Jun 2015 18:54:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 1BA13204B0 for ; Mon, 15 Jun 2015 18:54:12 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4BFEB265707; Mon, 15 Jun 2015 20:54:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 9F31126058D; Mon, 15 Jun 2015 20:52:39 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 01FC4266507; Thu, 11 Jun 2015 15:14:47 +0200 (CEST) Received: from Galois.linutronix.de (www.linutronix.de [62.245.132.108]) by alsa0.perex.cz (Postfix) with ESMTP id 218B32664BB for ; Thu, 11 Jun 2015 15:14:41 +0200 (CEST) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1Z32JW-0006Y9-P1; Thu, 11 Jun 2015 15:14:34 +0200 Date: Thu, 11 Jun 2015 15:14:34 +0200 From: Sebastian Andrzej Siewior To: Mats Karrman Message-ID: <20150611131434.GI16115@linutronix.de> References: <20150519213923.GA26363@linutronix.de> <55623BC2.80307@localhost> <20150611122227.GF16115@linutronix.de> <55798759.8000607@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <55798759.8000607@gmail.com> X-Key-Id: 2A8CF5D1 X-Key-Fingerprint: 6425 4695 FFF0 AA44 66CC 19E6 7B96 E816 2A8C F5D1 User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Mon, 15 Jun 2015 20:52:36 +0200 Cc: alsa-devel@alsa-project.org, linux-rt-users , Vinod Koul , LKML , rostedt@goodmis.org, Fernando Lopez-Lezcano , Mark Brown , John Kacur , Thomas Gleixner Subject: [alsa-devel] [PATCH v2] ASoC: Intel: sst: use ; instead of , at the of a C statement X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This was spotted by Fernando Lopez-Lezcano while he tried to compile a -RT kernel with this driver enabled. "make C=2" would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano Signed-off-by: Sebastian Andrzej Siewior --- * Mats Karrman | 2015-06-11 15:04:25 [+0200]: >>+ sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): >Don't you mean ';' and not ':'? Interresting, yes I do. Thanks. sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..a4b458e77089 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), - sst_shim_write64(shim, SST_CSR, shim_regs->csr), + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx); + sst_shim_write64(shim, SST_CSR, shim_regs->csr); spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); }