From patchwork Fri Aug 26 15:50:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9302019 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1E0D260757 for ; Fri, 26 Aug 2016 20:22:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 103C629649 for ; Fri, 26 Aug 2016 20:22:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 04D3529652; Fri, 26 Aug 2016 20:22:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 24FA229649 for ; Fri, 26 Aug 2016 20:22:33 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 32FF52671DE; Fri, 26 Aug 2016 22:22:32 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8DE6C266F8F; Fri, 26 Aug 2016 21:35:13 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3E2FD26757C; Fri, 26 Aug 2016 21:35:11 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by alsa0.perex.cz (Postfix) with ESMTP id 3A7AC266552 for ; Fri, 26 Aug 2016 17:51:33 +0200 (CEST) Received: from wuerfel.lan. ([176.0.135.42]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0MFRbQ-1brac23Ew8-00ENMI; Fri, 26 Aug 2016 17:51:23 +0200 From: Arnd Bergmann To: Mark Brown Date: Fri, 26 Aug 2016 17:50:55 +0200 Message-Id: <20160826155120.1162512-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:zFPiTOSOKnFhJtFbaAqQwbW6h3r+CV2kOBR9x2A+gwH9Xrhm4Dq I5COhD+U6iw5Cr8pS96wZ5+z1uBv7mHO47cXSgrouSfF/eQWbJxaRDWyowmT4WUoL6i5U2o nBl+aWzhEVF+6AjdV7fY0vE1i55rIvwXxH1r2JgxWF586/QKAt+0MwOl5fo7/b5e+PCav5x 1iaQ8LzWq1mnwdqDcYEmQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:wI2c0sgWLUk=:4SCFB2QZGea5Ei7Uwf2+4N RIR9e4yog59ihDw3Fez7ikZ3gI5TAUWYJl59jRysKDGDmXQ0rTfb7if337ThlgHAH6YKHJr3D jSdiBCek9kGCZ4LLE0hNNqI+1/xFzW1nHdVCrKDD3LiQRl/0In7EEkp4jLWnOsn+xxWo3VeYE 8d8TPZPGzvwBq2zsUsfeI/mRzjgXVfaj5p/yd/rOkB3gIu7OLenFxQY+I1Lsvp3UL4X3VApuq LlY9wWFPhfPa7XIx1YLJCqROdoE2RP3q7/75YlJTXIy6BkRdpzodsaKdVM9BTJ1k8zUfXpPtx 2zx/PI72fqETAyeUXmqIlWkeAleDwj9ydWHsSVJo1cVhK6J5q/GOBEOqaRZo3l9s+FP0PzP9z XVD1JPWBfxsnLiHoxeuu2U5sNaJoN4c4wmEhc/9+UjKN4D5fdXg4BKSPznZ9+YU+7G8PKrPA4 ouhrfD07qMeQANrCGfE7q1x8ARTDQjEfAqbDLicPX3kItamu8w4+n7avlj1Xu04J1Imufu8wp R9m9BrIc3MnJtIqmZBL2BitgaBPMcl7zEELZ1Dnu9tikQR/6u7JXiegeGs5cQosguM8HoheFL YMyotI3DMG7VV5DNCKGAZ4SV5sGHhL7QGZEPpvoYsUo4pcZETGuZT5eYjS9+UuqBCpIY7Xra8 QqaUdA0E8Fa+axdO+wcXcR50HOy/VjJ6IdvFO9dXgNrMHpwTZZShGwTg0LuvS5JfOLnU= Cc: alsa-devel@alsa-project.org, Arnd Bergmann , Xing Zheng , Liam Girdwood , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Sjoerd Simons , linux-arm-kernel@lists.infradead.org, Heiko Stuebner Subject: [alsa-devel] [PATCH] ASoC: rockchip: use SPI dependency for rt5514 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The rk3399 scans the spi_bus_type to find the rt5514 driver, but does not actually have a Kconfig dependency on SPI, so we can end up with a link failure: sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_driver_init': rt5514-spi.c:(.init.text+0x14): undefined reference to `__spi_register_driver' sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_burst_read': rt5514-spi.c:(.text.rt5514_spi_burst_read+0x18c): undefined reference to `spi_sync' sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_burst_write': rt5514-spi.c:(.text.rt5514_spi_burst_write+0x1b4): undefined reference to `spi_sync' sound/soc/rockchip/snd-soc-rk3399-gru-sound.o: In function `rockchip_sound_probe': rk3399_gru_sound.c:(.text.rockchip_sound_probe+0x128): undefined reference to `spi_bus_type' This adds the missing dependency. Signed-off-by: Arnd Bergmann Fixes: c6eac8a36a84 ("ASoC: rockchip: Add machine driver for RK3399 GRU Boards") --- sound/soc/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index d82d763d4854..c783f9a22595 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -44,7 +44,7 @@ config SND_SOC_ROCKCHIP_RT5645 config SND_SOC_RK3399_GRU_SOUND tristate "ASoC support multiple codecs for Rockchip RK3399 GRU boards" - depends on SND_SOC_ROCKCHIP && I2C && GPIOLIB && CLKDEV_LOOKUP + depends on SND_SOC_ROCKCHIP && I2C && GPIOLIB && CLKDEV_LOOKUP && SPI select SND_SOC_ROCKCHIP_I2S select SND_SOC_MAX98357A select SND_SOC_RT5514