From patchwork Fri Dec 16 11:05:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Thomson X-Patchwork-Id: 9477775 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 20DF7607EE for ; Fri, 16 Dec 2016 11:14:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 123C5287E6 for ; Fri, 16 Dec 2016 11:14:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06E5F287EC; Fri, 16 Dec 2016 11:14:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=2.0 tests=BAYES_00,FROM_WORDY, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 327C3287E7 for ; Fri, 16 Dec 2016 11:14:33 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6E79D2668AD; Fri, 16 Dec 2016 12:14:32 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 7941F26757E; Fri, 16 Dec 2016 12:12:13 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 447BA267576; Fri, 16 Dec 2016 12:05:10 +0100 (CET) Received: from mail1.bemta3.messagelabs.com (mail1.bemta3.messagelabs.com [195.245.230.167]) by alsa0.perex.cz (Postfix) with ESMTP id 05375267588 for ; Fri, 16 Dec 2016 12:05:05 +0100 (CET) Received: from [85.158.137.99] by server-7.bemta-3.messagelabs.com id 0B/08-23854-06AC3585; Fri, 16 Dec 2016 11:05:04 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRWlGSWpSXmKPExsUSt3OpsW78qeA Ig88LDC2uXDzEZDH14RM2i29XOpgsLu+aw2bRuauf1WLD97WMDmweGz43sXnsnHWX3WPTqk42 j31vl7F5rN9ylcXj8ya5ALYo1sy8pPyKBNaMI42yBZM4K57+F25gfMLexcjFISSwnlGia/lM1 i5GTiCnQmLW3i3sIDabgIXE5BMP2EBsFgFVicUztgHFOTiEBQIlNhxmA+kVEehilFj96jFYPb NAucSWTxOZQWxeAQeJ6duusULYghInZz5hgaiRkDj44gUzxC4DidMLGsHiEgL2EtPfX2UGmS8 hoC/ReCwWImwo8X3WN6gSc4nuBZeYJzDyz0IydRaSqQsYmVYxqhenFpWlFuma6iUVZaZnlOQm ZuboGhoY6+WmFhcnpqfmJCYV6yXn525iBAZyPQMD4w7Gy1+dDjFKcjApifIu3xEcIcSXlJ9Sm ZFYnBFfVJqTWnyIUYaDQ0mCV/MkUE6wKDU9tSItMwcYUzBpCQ4eJRFeX5A0b3FBYm5xZjpE6h SjopQ479cTQAkBkERGaR5cGyyOLzHKSgnzMjIwMAjxFKQW5WaWoMq/YhTnYFQS5n0LMoUnM68 EbvoroMVMQIst5oEtLklESEk1MD5Y1PF6Y4zTpOm5DTXGC2R3PQxdOP39LWs3MyO5sNKI7783 GZxavMiswyjv7vll9rOyl2R1qxpMkUoqXy195daD06c2Lj812+C+Wyxj/o6wurk3TrNrzVZef ma9a9ih93vWv65Kjs1akLfU4BTjcqO7PfsrlizQNXj91i+Hb651QFjhL2/ZfVeVWIozEg21mI uKEwEzYvlL3gIAAA== X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-13.tower-217.messagelabs.com!1481886303!70665870!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2431 invoked from network); 16 Dec 2016 11:05:03 -0000 Received: from mailrelay2.diasemi.com (HELO sw-ex-cashub01.diasemi.com) (94.185.165.51) by server-13.tower-217.messagelabs.com with AES128-SHA encrypted SMTP; 16 Dec 2016 11:05:03 -0000 Received: from swsrvapps-01.diasemi.com (10.20.28.141) by SW-EX-CASHUB01.diasemi.com (10.20.16.140) with Microsoft SMTP Server id 14.3.248.2; Fri, 16 Dec 2016 11:05:02 +0000 Received: by swsrvapps-01.diasemi.com (Postfix, from userid 22379) id 849053FA9F; Fri, 16 Dec 2016 11:05:02 +0000 (GMT) From: Adam Thomson Date: Fri, 16 Dec 2016 11:05:02 +0000 To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai Message-ID: <20161216110502.849053FA9F@swsrvapps-01.diasemi.com> MIME-Version: 1.0 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 16/12/2016 08:47:00 Cc: alsa-devel@alsa-project.org, Support Opensource , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH] ASoC: da7218: Set DAI output pin high impedance when not in use X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP For TDM mode, the I2S data out line can be shared between mutliple codecs. In this scenario, only the active codec should be using the line, and all others should be high impedance. However, currently in the driver this configuration isn't set when capture is inactive, and the line remains driven. This patch updates the AIF_OUT widget to set the DAI output pin of the device as high impedance when not in use. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7218.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index c69e976..d256ebf 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -1634,7 +1634,8 @@ static int da7218_hp_pga_event(struct snd_soc_dapm_widget *w, SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD), /* DAI */ - SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, DA7218_DAI_TDM_CTRL, + DA7218_DAI_OE_SHIFT, DA7218_NO_INVERT), SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0), /* Output Mixers */