| Message ID | 20170112173343.9953-1-codekipper@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cb5c978f9a56c459d5f13901efcfe44b97c4182d |
| Headers | show |
On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekipper@gmail.com wrote: > From: Marcus Cooper <codekipper@gmail.com> > > The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the > transmit fifo is at a different address. > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekipper@gmail.com wrote: > From: Marcus Cooper <codekipper@gmail.com> > > The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the > transmit fifo is at a different address. > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> > --- > Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 1 + > 1 file changed, 1 insertion(+) This is fine but it doesn't actually add the compatible string to the driver which I'd expect.
On 17 January 2017 at 19:15, Mark Brown <broonie@kernel.org> wrote: > On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekipper@gmail.com wrote: >> From: Marcus Cooper <codekipper@gmail.com> >> >> The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the >> transmit fifo is at a different address. >> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> >> --- >> Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 1 + >> 1 file changed, 1 insertion(+) > > This is fine but it doesn't actually add the compatible string to the > driver which I'd expect. Hi Mark, I missed the binding documentation on the patch for the driver so I pushed it separately instead of pushing a new patch version. You can find it under the subject heading 'ASoC: sun4i-spdif: Add support for the H3 SoC' and Maxime has ACK it (on the condition that I add the binding doc). BR, CK > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote: > I missed the binding documentation on the patch for the driver so I > pushed it separately instead of pushing a new patch version. > You can find it under the subject heading 'ASoC: sun4i-spdif: Add > support for the H3 SoC' and Maxime has ACK it (on the condition that I > add the binding doc). I don't seem to have that patch. If Maxime said it needed changes for him to ack it there's every chance I just deleted it waiting for you to resend, it's certainly confusing to see a patch like this without the matching code.
On 19 January 2017 at 18:03, Mark Brown <broonie@kernel.org> wrote: > On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote: > >> I missed the binding documentation on the patch for the driver so I >> pushed it separately instead of pushing a new patch version. >> You can find it under the subject heading 'ASoC: sun4i-spdif: Add >> support for the H3 SoC' and Maxime has ACK it (on the condition that I >> add the binding doc). > > I don't seem to have that patch. If Maxime said it needed changes for > him to ack it there's every chance I just deleted it waiting for you to > resend, it's certainly confusing to see a patch like this without the > matching code. No worries...I'll squash this patch into it and send as a V2. CK
diff --git a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt index 0230c4d20506..fe0a65e6d629 100644 --- a/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt +++ b/Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt @@ -10,6 +10,7 @@ Required properties: - compatible : should be one of the following: - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC + - "allwinner,sun8i-h3-spdif": for the Allwinner H3 SoC - reg : Offset and length of the register set for the device.