From patchwork Mon Nov 6 13:30:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10043473 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B3E2602BF for ; Mon, 6 Nov 2017 13:31:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4425829C79 for ; Mon, 6 Nov 2017 13:31:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3653429C89; Mon, 6 Nov 2017 13:31:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 323DA29C79 for ; Mon, 6 Nov 2017 13:31:44 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id B0EFD2671F3; Mon, 6 Nov 2017 14:31:42 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 279952671F9; Mon, 6 Nov 2017 14:31:41 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by alsa0.perex.cz (Postfix) with ESMTP id 4C1FD26716A for ; Mon, 6 Nov 2017 14:31:37 +0100 (CET) Received: from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MUQni-1ecY2G3sqA-00R2B8; Mon, 06 Nov 2017 14:31:19 +0100 From: Arnd Bergmann To: Mark Brown , Vinod Koul , Guneshwor Singh Date: Mon, 6 Nov 2017 14:30:36 +0100 Message-Id: <20171106133114.339667-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:GwUFKiakQGD7rW8DZjNfWJjJFWSrXEKHordrekoFwXiK7oRyVmF HANIiUKsRioDrEClG11rEGcb7bEhod8PyE8AGp9hDIA7QgvgP4ZjKQwi3OQlhV9qVvh+j3K D10xDDjgFUf8T6Aanegbi6Ezbu4rkIC0qY0+53ywyzoGaMplN+YzhXko0JnAzzGx+byXXF6 M1oLZvwyaNjM5/0Vk+XbQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:U3FTiTRJ2N8=:x2e04Wu56dqNSCFDOLc/3O Iwyw1xXilEioIMYDIw1gWCQAOPKF1QLYJPbGLB4WcpZi2W7TzPQMqmfrZxT4+BOsoHN47dcy7 mKpI/3dHlCyk+JgQ+Icw0h5KtcjJa2qZohN5qRq2ykl/w4x0myPC/mWxB0Vwev9zDWEmzRDK6 eDZz1Zwsxo7lCnkIYDiOH3D9EY81ZPY7mhQfo3zfv7+uD6gvnXPDBmr+uhN1FdYajg74dw9SI vMgCLX9Q6IQgJ7CgD28KIvLNwGyR7EIfOtX2FP65oEQ5wQkD2OJmfKm5NFaptpudoObbOEj7x CoXY2zCT7/tVO6V0QoYHcNUS6CGJf70P32KHNLPay2i/FD1iN70WSBSIzUMmrXjQZC+ZayJ4x EjQJtP4vB2a4if84n4reIJaJzU7IT50d760UJkMX/f7xeZ3WRzRgp6/FDR6XUsgjNq1vJrLJN kCNs0SRxX21G/+AiE8KWpPmXqhBk0/F1JxGML6o0pyFk7tP9hEKND169sTM/z8ZJkXrkgawOA mltYZYaAni12ujMvAABz/NqV1xFqBJhz8IAsYXK+EYC5vtOP74rCmSn4EJAuHRq3s9CEz8oNy 3JmFkPNBySbeCg4qkIaLWHFSQJVs7R66TkWWz+xK5P3M5gGpTlIxSQ4SKrNSqNjjiTmn2ySI2 gCGYEmOgX5QF74W09z72z2vSCJvoDfay5f/exN1s9bI7HvnMKR7WbGaVQgrvuayVBas8rTTjs 3O+1pYeJ0Q+IUaUJYE1uAfcJ6eGWqMkDOFa2VA== Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Arnd Bergmann , Harsha Priya N , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Naveen Manohar , "Subhransu S. Prusty" Subject: [alsa-devel] [PATCH] ASoC: intel: initialize return value properly X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP When CONFIG_SND_SOC_HDAC_HDMI is disabled, we can run into an uninitialized variable: sound/soc/intel/skylake/skl.c: In function 'skl_resume': sound/soc/intel/skylake/skl.c:326:6: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] I have run into this on today's linux-next kernel, but it appears that this is an older problem that was just hard to trigger with randconfig builds as CONFIG_SND_SOC_HDAC_HDMI would in effect be impossible to disable when having SND_SOC_INTEL_SKYLAKE enabled. Signed-off-by: Arnd Bergmann Acked-By: Vinod Koul --- sound/soc/intel/skylake/skl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 31d8634e8aa1..acb0ab470ca6 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -355,6 +355,7 @@ static int skl_resume(struct device *dev) if (ebus->cmd_dma_state) snd_hdac_bus_init_cmd_io(&ebus->bus); + ret = 0; } else { ret = _skl_resume(ebus);