From patchwork Tue Dec 5 12:47:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 10092869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 35134605BA for ; Tue, 5 Dec 2017 12:47:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 217C2287FA for ; Tue, 5 Dec 2017 12:47:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 168F728CE6; Tue, 5 Dec 2017 12:47:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5425E287FA for ; Tue, 5 Dec 2017 12:47:32 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F0010267734; Tue, 5 Dec 2017 13:47:30 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D7B4326773B; Tue, 5 Dec 2017 13:47:28 +0100 (CET) Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by alsa0.perex.cz (Postfix) with ESMTP id A5365267746 for ; Tue, 5 Dec 2017 13:47:18 +0100 (CET) Received: by mail.free-electrons.com (Postfix, from userid 110) id 376B020741; Tue, 5 Dec 2017 13:47:17 +0100 (CET) Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 0D8A42036E; Tue, 5 Dec 2017 13:47:07 +0100 (CET) Date: Tue, 5 Dec 2017 13:47:07 +0100 From: Alexandre Belloni To: Arnd Bergmann Message-ID: <20171205124707.GJ21780@piout.net> References: <20171205101000.968887-1-arnd@arndb.de> <20171205105750.GI21780@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Cc: alsa-devel@alsa-project.org, Liam Girdwood , Linux Kernel Mailing List , Nicolas Ferre , Takashi Iwai , Mark Brown , Linux ARM Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-classd: select correct Kconfig symbol X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni > wrote: > > On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: > >> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > >> changed the way that the dependencies are handled, but then the > >> Class D amplifier support got merged, which used the old method. > >> > >> This seems to have triggered a very rare randconfig condition for me > >> now, leading to a link error: > >> > >> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': > >> atmel_ssc_dai.c:(.text+0x79c): undefined reference to `atmel_pcm_dma_platform_register' > >> atmel_ssc_dai.c:(.text+0x79c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_register' > >> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_put_audio': > >> atmel_ssc_dai.c:(.text+0xf24): undefined reference to `atmel_pcm_dma_platform_unregister' > >> atmel_ssc_dai.c:(.text+0xf24): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_unregister' > >> > >> Changing it to select SND_ATMEL_SOC_SSC_DMA as intended rather than > >> SND_ATMEL_SOC_DMA directly makes it work again. > >> > >> Fixes: e0a25b6d1862 ("ASoC: atmel-classd: add the Audio Class D Amplifier") > >> Signed-off-by: Arnd Bergmann > > Acked-by: Alexandre Belloni > > Unfortunately, my testing just found a new problem with this patch > applied, I had > not run enough randconfig tests on top of it: > > sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': > atmel_ssc_dai.c:(.text+0x73c): undefined reference to `ssc_request' > sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_put_audio': > atmel_ssc_dai.c:(.text+0x7be): undefined reference to `ssc_free' > > This is for a configuration with SND_ATMEL_SOC_CLASSD=y > and CONFIG_ATMEL_SSC=n. Could you tell me whether that is a > sensible configuration that should work, or whether we need a dependency > on ATMEL_SSC in SND_ATMEL_SOC_CLASSD? I can't really tell > from the source code, but you probably know the answer. > Ok, does that solve both randconfigs? Tested-by: Arnd Bergmann diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 4a56f3dfba51..dcee145dd179 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731 config SND_ATMEL_SOC_CLASSD tristate "Atmel ASoC driver for boards using CLASSD" depends on ARCH_AT91 || COMPILE_TEST - select SND_ATMEL_SOC_DMA + select SND_SOC_GENERIC_DMAENGINE_PCM select REGMAP_MMIO help Say Y if you want to add support for Atmel ASoC driver for boards using