From patchwork Fri Feb 2 17:36:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 10197551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AF4E860388 for ; Fri, 2 Feb 2018 17:31:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E6F028EF5 for ; Fri, 2 Feb 2018 17:31:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 92BAA28F01; Fri, 2 Feb 2018 17:31:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CD4128EF5 for ; Fri, 2 Feb 2018 17:31:51 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id EF9E826794C; Fri, 2 Feb 2018 18:31:48 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2F63026794E; Fri, 2 Feb 2018 18:31:46 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by alsa0.perex.cz (Postfix) with ESMTP id 4506D26791F for ; Fri, 2 Feb 2018 18:31:41 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Feb 2018 09:31:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,450,1511856000"; d="scan'208";a="24441077" Received: from vkoul-udesk7.iind.intel.com (HELO localhost) ([10.223.84.143]) by FMSMGA003.fm.intel.com with ESMTP; 02 Feb 2018 09:31:37 -0800 Date: Fri, 2 Feb 2018 23:06:16 +0530 From: Vinod Koul To: Katsuhiro Suzuki Message-ID: <20180202173616.GI18649@localhost> References: <20180202043246.10481-1-suzuki.katsuhiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180202043246.10481-1-suzuki.katsuhiro@socionext.com> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Jassi Brar , alsa-devel@alsa-project.org, Takashi Iwai , Masami Hiramatsu Subject: Re: [alsa-devel] [PATCH v2 1/3] cplay: add option to specify codec ID X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Feb 02, 2018 at 01:32:44PM +0900, Katsuhiro Suzuki wrote: > This patch adds a -I command line option to set the codec ID, > same as crecord. Applied all 3 patches with below nit fix, thanks diff --git a/src/utils/cplay.c b/src/utils/cplay.c index f15c72876fb0..98d71a2199da 100644 --- a/src/utils/cplay.c +++ b/src/utils/cplay.c @@ -304,7 +304,7 @@ void get_codec_mp3(FILE *file, struct compr_config *config, codec->format = 0; } -int get_codec_iec(FILE *file, struct compr_config *config, +void get_codec_iec(FILE *file, struct compr_config *config, struct snd_codec *codec) { codec->id = SND_AUDIOCODEC_IEC61937;