From patchwork Thu Apr 12 16:01:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Andrushchenko X-Patchwork-Id: 10338925 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A62C2604D4 for ; Thu, 12 Apr 2018 16:05:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94474209CC for ; Thu, 12 Apr 2018 16:05:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8807624BFE; Thu, 12 Apr 2018 16:05:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB33D2852D for ; Thu, 12 Apr 2018 16:02:11 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 6F0E126735C; Thu, 12 Apr 2018 18:01:42 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0F06E2675C9; Thu, 12 Apr 2018 18:01:38 +0200 (CEST) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by alsa0.perex.cz (Postfix) with ESMTP id 81ABD26735C for ; Thu, 12 Apr 2018 18:01:35 +0200 (CEST) Received: by mail-lf0-f67.google.com with SMTP id m200-v6so8471910lfm.4 for ; Thu, 12 Apr 2018 09:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kByviSoXbQwS7PzbXRmJGzHa4neQSB3a/Sn7Db9kyYw=; b=rr4n2LuMVE3W5BgaouSgalPmMVzeHFh3MqUeq47X1BpqckUZGZSY/xHehfqp0tHENj hNTeFWxB6uspDrZqjPmi0y+e9kkMLmkOt1PTPzPzo1Vmqs8MbV8T+u/T8agnZB6CIAFo a7jMyFRa4dFLnq7jYNIDyans3xHwbyLaj8LW8Su0c9AW931MXzXwMzW+2RcYjLvWE0RJ RQBCQGd2nDbhhGDeiu0CXUWCerC1htD7DmagLUWrSgja9vH3EiubZ3R7axhtu6JdfqkO Q8OD3zQlqCWBSPUC6P1geKzJG01ZyoE7k2iXz8o4JElh5DItqDvvmRExKDtkX2GpEDUi 636Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kByviSoXbQwS7PzbXRmJGzHa4neQSB3a/Sn7Db9kyYw=; b=p2CoAXr8Uhiv4+CEDHfPaoWq2VzFANws7Te2msQ+GSljTADGRWGTIYSCYtUeiJslys A/f1uP9y+LurOcqlvM8wI4+2qpCu/hK153LlHY94u94a0o2/FU9WI52xGabypDJPDvec FlwgQlKFXxmTy/d2Qjt+c2cPQ9W4vCZwrBwxghJVC1svHqo5EW73QvarFpX9zXD6KZ7o Y8ysVJmBm8GhGJRTqZc0G420UBGJaBMIbJ5thWCIpak8srVFkzGGR+O7hRJUelq1TM46 kSCPKcwPJB7wH6MYqfqd+tWOV69Fdl7VL1ETxrvZLYeZC7WIKIqI3a5eUZjezr3z+A+g LSUQ== X-Gm-Message-State: ALQs6tBtKq1Qnl7OF9TagTJJAtxI2OzEk336Z04iNvP38PpL9cBRGkPo OxNvLnuTkUUqhy1yJnoDtfQ= X-Google-Smtp-Source: AIpwx4/jv4RBKrnikBzd+PErEvkPZ0D7mZtqrEKH7lwDsFdl6WeSCDmAkd2CYL5MpWzLlyzGdhDJ2Q== X-Received: by 2002:a19:274b:: with SMTP id n72-v6mr5836469lfn.48.1523548894465; Thu, 12 Apr 2018 09:01:34 -0700 (PDT) Received: from localhost.localdomain (207-17-94-178.pool.ukrtel.net. [178.94.17.207]) by smtp.gmail.com with ESMTPSA id m11sm644541ljh.37.2018.04.12.09.01.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Apr 2018 09:01:33 -0700 (PDT) From: Oleksandr Andrushchenko X-Google-Original-From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Date: Thu, 12 Apr 2018 19:01:02 +0300 Message-Id: <20180412160102.15833-6-oleksandr_andrushchenko@epam.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180412160102.15833-1-oleksandr_andrushchenko@epam.com> References: <20180412160102.15833-1-oleksandr_andrushchenko@epam.com> Cc: jgross@suse.com, iurii.konovalenko@globallogic.com, konrad.wilk@oracle.com, tiwai@suse.de, oleksandr.dmytryshyn@globallogic.com, andr2000@gmail.com, boris.ostrovsky@oracle.com Subject: [alsa-devel] [PATCH 5/5] xen/sndif: Add explicit back and front parameter negotiation X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP In order to provide explicit stream parameter negotiation between backend and frontend the following changes are introduced in the protocol: add XENSND_OP_HW_PARAM_QUERY request to read/update configuration space for the parameters given: request passes desired parameter's intervals/masks and the response to this request returns allowed min/max intervals/masks to be used. Parameters supported by this request/response: - format mask - sample rate interval - number of channels interval - buffer size, interval, frames - period size, interval, frames Signed-off-by: Oleksandr Andrushchenko Cc: Konrad Rzeszutek Wilk Cc: Takashi Iwai --- include/xen/interface/io/sndif.h | 133 +++++++++++++++++++++++++++++-- 1 file changed, 126 insertions(+), 7 deletions(-) diff --git a/include/xen/interface/io/sndif.h b/include/xen/interface/io/sndif.h index 131c3b469d4a..78bb5d9f8d83 100644 --- a/include/xen/interface/io/sndif.h +++ b/include/xen/interface/io/sndif.h @@ -465,6 +465,7 @@ #define XENSND_OP_MUTE 6 #define XENSND_OP_UNMUTE 7 #define XENSND_OP_TRIGGER 8 +#define XENSND_OP_HW_PARAM_QUERY 9 #define XENSND_OP_TRIGGER_START 0 #define XENSND_OP_TRIGGER_PAUSE 1 @@ -832,28 +833,142 @@ struct xensnd_trigger_req { }; /* - *---------------------------------- Responses -------------------------------- + * Request stream parameter ranges: request intervals and + * masks of supported ranges for stream configuration values. * - * All response packets have the same length (64 octets) + * Sound device configuration for a particular stream is a limited subset + * of the multidimensional configuration available on XenStore, e.g. + * once the frame rate has been selected there is a limited supported range + * for sample rates becomes available (which might be the same set configured + * on XenStore or less). For example, selecting 96kHz sample rate may limit + * number of channels available for such configuration from 4 to 2, etc. + * Thus, each call to XENSND_OP_HW_PARAM_QUERY may reduce configuration + * space making it possible to iteratively get the final stream configuration, + * used in XENSND_OP_OPEN request. + * + * See response format for this request. * - * Response for all requests: * 0 1 2 3 octet * +----------------+----------------+----------------+----------------+ - * | id | operation | reserved | 4 + * | id | _HW_PARAM_QUERY| reserved | 4 * +----------------+----------------+----------------+----------------+ - * | status | 8 + * | reserved | 8 + * +----------------+----------------+----------------+----------------+ + * | formats mask low 32-bit | 12 + * +----------------+----------------+----------------+----------------+ + * | formats mask high 32-bit | 16 + * +----------------+----------------+----------------+----------------+ + * | min rate | 20 + * +----------------+----------------+----------------+----------------+ + * | max rate | 24 + * +----------------+----------------+----------------+----------------+ + * | min channels | 28 + * +----------------+----------------+----------------+----------------+ + * | max channels | 32 + * +----------------+----------------+----------------+----------------+ + * | min buffer frames | 36 + * +----------------+----------------+----------------+----------------+ + * | max buffer frames | 40 + * +----------------+----------------+----------------+----------------+ + * | min period frames | 44 + * +----------------+----------------+----------------+----------------+ + * | max period frames | 48 * +----------------+----------------+----------------+----------------+ - * | reserved | 12 + * | reserved | 52 * +----------------+----------------+----------------+----------------+ * |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/| * +----------------+----------------+----------------+----------------+ * | reserved | 64 * +----------------+----------------+----------------+----------------+ * + * formats - uint64_t, bit mask representing values of the parameter + * made as bitwise OR of (1 << XENSND_PCM_FORMAT_XXX) values + * + * For interval parameters: + * min - uint32_t, minimum value of the parameter + * max - uint32_t, maximum value of the parameter + * + * Frame is defined as a product of the number of channels by the + * number of octets per one sample. + */ + +struct xensnd_query_hw_param { + uint64_t formats; + struct { + uint32_t min; + uint32_t max; + } rates; + struct { + uint32_t min; + uint32_t max; + } channels; + struct { + uint32_t min; + uint32_t max; + } buffer; + struct { + uint32_t min; + uint32_t max; + } period; +}; + +/* + *---------------------------------- Responses -------------------------------- + * + * All response packets have the same length (64 octets) + * + * All response packets have common header: + * 0 1 2 3 octet + * +----------------+----------------+----------------+----------------+ + * | id | operation | reserved | 4 + * +----------------+----------------+----------------+----------------+ + * | status | 8 + * +----------------+----------------+----------------+----------------+ + * * id - uint16_t, copied from the request * operation - uint8_t, XENSND_OP_* - copied from request * status - int32_t, response status, zero on success and -XEN_EXX on failure * + * + * HW parameter query response - response for XENSND_OP_HW_PARAM_QUERY: + * 0 1 2 3 octet + * +----------------+----------------+----------------+----------------+ + * | id | operation | reserved | 4 + * +----------------+----------------+----------------+----------------+ + * | status | 8 + * +----------------+----------------+----------------+----------------+ + * | formats mask low 32-bit | 12 + * +----------------+----------------+----------------+----------------+ + * | formats mask high 32-bit | 16 + * +----------------+----------------+----------------+----------------+ + * | min rate | 20 + * +----------------+----------------+----------------+----------------+ + * | max rate | 24 + * +----------------+----------------+----------------+----------------+ + * | min channels | 28 + * +----------------+----------------+----------------+----------------+ + * | max channels | 32 + * +----------------+----------------+----------------+----------------+ + * | min buffer frames | 36 + * +----------------+----------------+----------------+----------------+ + * | max buffer frames | 40 + * +----------------+----------------+----------------+----------------+ + * | min period frames | 44 + * +----------------+----------------+----------------+----------------+ + * | max period frames | 48 + * +----------------+----------------+----------------+----------------+ + * | reserved | 52 + * +----------------+----------------+----------------+----------------+ + * |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/| + * +----------------+----------------+----------------+----------------+ + * | reserved | 64 + * +----------------+----------------+----------------+----------------+ + * + * Meaning of the values in this response is the same as for + * XENSND_OP_HW_PARAM_QUERY request. + */ + +/* *----------------------------------- Events ---------------------------------- * * Events are sent via shared page allocated by the front and propagated by @@ -906,6 +1021,7 @@ struct xensnd_req { struct xensnd_open_req open; struct xensnd_rw_req rw; struct xensnd_trigger_req trigger; + struct xensnd_query_hw_param hw_param; uint8_t reserved[56]; } op; }; @@ -915,7 +1031,10 @@ struct xensnd_resp { uint8_t operation; uint8_t reserved; int32_t status; - uint8_t reserved1[56]; + union { + struct xensnd_query_hw_param hw_param; + uint8_t reserved1[56]; + } resp; }; struct xensnd_evt {