| Message ID | 20180606093504.30255-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 510e419cb85798915c6426c496a164ec6328d1a7 |
| Headers | show |
Hi, On 2018-06-06 12:35, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointer dmic_codec_dev is local to the source and does not need > to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'dmic_codec_dev' was not declared. Should it be static? can you change the subject to: ASoC: omap-abe-twl6040: make pointer dmic_codec_dev static With that change: Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > sound/soc/omap/omap-abe-twl6040.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/omap/omap-abe-twl6040.c b/sound/soc/omap/omap-abe-twl6040.c > index 15ccbf479c96..d5ae9eb8c756 100644 > --- a/sound/soc/omap/omap-abe-twl6040.c > +++ b/sound/soc/omap/omap-abe-twl6040.c > @@ -40,7 +40,7 @@ struct abe_twl6040 { > int mclk_freq; /* MCLK frequency speed for twl6040 */ > }; > > -struct platform_device *dmic_codec_dev; > +static struct platform_device *dmic_codec_dev; > > static int omap_abe_hw_params(struct snd_pcm_substream *substream, > struct snd_pcm_hw_params *params) > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff --git a/sound/soc/omap/omap-abe-twl6040.c b/sound/soc/omap/omap-abe-twl6040.c index 15ccbf479c96..d5ae9eb8c756 100644 --- a/sound/soc/omap/omap-abe-twl6040.c +++ b/sound/soc/omap/omap-abe-twl6040.c @@ -40,7 +40,7 @@ struct abe_twl6040 { int mclk_freq; /* MCLK frequency speed for twl6040 */ }; -struct platform_device *dmic_codec_dev; +static struct platform_device *dmic_codec_dev; static int omap_abe_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params)