From patchwork Fri Jul 20 08:04:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 10536181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F00EF602CA for ; Fri, 20 Jul 2018 08:04:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF63229181 for ; Fri, 20 Jul 2018 08:04:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D39612961B; Fri, 20 Jul 2018 08:04:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B69329181 for ; Fri, 20 Jul 2018 08:04:50 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1A329267711; Fri, 20 Jul 2018 10:04:49 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 94D5026774A; Fri, 20 Jul 2018 10:04:46 +0200 (CEST) Received: from mout.perfora.net (mout.perfora.net [74.208.4.196]) by alsa0.perex.cz (Postfix) with ESMTP id A3D1026770A for ; Fri, 20 Jul 2018 10:04:44 +0200 (CEST) Received: from localhost.localdomain.ziswiler.net ([89.217.215.226]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0MRmud-1fZf4934tV-00SyRn; Fri, 20 Jul 2018 10:04:37 +0200 From: Marcel Ziswiler To: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org Date: Fri, 20 Jul 2018 10:04:24 +0200 Message-Id: <20180720080424.31505-2-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180720080424.31505-1-marcel@ziswiler.com> References: <20180720080424.31505-1-marcel@ziswiler.com> X-Provags-ID: V03:K1:ont/fEOq6Ti2cNWyJh7UAxOMsT+dtNakUjlzMR2TwzPf5d6Keaf MNU7ULd71P23UgBCXtQFW99AIASL5aPtzG1J2Fxb01yCQuixhQ1YQindQXJJkp5V7hn20uE /dOglQdf41A39yQjzuko97qf2bSo9g+yqiWRFlCDMaJCiRhrChICd9uaRVznDRjEXtjVM6U cKxM7SAWtvXwBZm0qTSgg== X-UI-Out-Filterresults: notjunk:1; V01:K0:r1pop4lALAk=:Nz1Wefe8hOC0/IeREgk3jw p6TRSqxpyC+tqMLkLAzCupYlyBbSqSj+8MrPxKogbF+AVyIIc9ohCOnh9hoXKwBF+UswQvMpx rGeHcn5dV4PdySauci4DxvXUJT2Q2WVmlVTy9+asrH5HcVGtQGKv6BnRtbhE0/DjGaW3e/S25 OsN/dqd7ududsE7oO7FtBczdrU58ZIjpmo/EGxncpOLKCnFMRjBjmAlUTKNlsYu7eFn9tIySA K/4x9APQ3MR4OOcqAXD+eZyHY4i19tR7fl6XmAsI7giVyrz6wPBKsrPT+Vs7yddScSi7A1MXh J7kkSBQWZkXmR4hs/FOFMgEXbfbnQwzw3uYlMVmaNzZcyDss8Y3K5VTLqmQZvfB5L+UcX5ybh FMnV4xofTlgnxPK3ObzGR8J1zG9/wEWvpjMHLWbsekhatBj4T4DWbuHfZ3TALxIYG5r21An5a 5Lh3CMHINqKcwsrHQCJ8LVUzvVSD/EytzBuFE8Ehsy6MxioZiLhI7J7jcxLAnf7jZyWFguZlI 3qUFyjraUqT4RkMYKvgvis8KEm4Ev/29w23tuSks+Do0iXQNV9N7QROFO8rXLZtJap3pz0NDP fcMyLD5PFJi2RabZnptSnGUUruIM/Xbu4a3/QPRWeLYNkihSi3/PHaVGtFIs8RJ8IDwekvJ9k 4DaV4E86tgf8e8p7D1jHQFiBO0n5N3US2PNJT/j6QZZp/Xmqebysve97o5xmYwbNKLVY= Cc: Liam Girdwood , Marcel Ziswiler , Takashi Iwai , linux-kernel@vger.kernel.org, Jonathan Hunter , Mark Brown , Thierry Reding Subject: [alsa-devel] [PATCH 2/2] ASoC: tegra: probe deferral error reporting X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Marcel Ziswiler Actually report the error codes from of_get_named_gpio() resp. devm_gpio_request_one() upon trying to get the codec reset resp. sync GPIOs which may as well just be a probe deferrals. Signed-off-by: Marcel Ziswiler --- sound/soc/tegra/tegra20_ac97.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c index 682ef33afb5f..4875512f0732 100644 --- a/sound/soc/tegra/tegra20_ac97.c +++ b/sound/soc/tegra/tegra20_ac97.c @@ -351,18 +351,21 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) ret = devm_gpio_request_one(&pdev->dev, ac97->reset_gpio, GPIOF_OUT_INIT_HIGH, "codec-reset"); if (ret) { - dev_err(&pdev->dev, "could not get codec-reset GPIO\n"); + dev_err(&pdev->dev, "could not get codec-reset GPIO: " + "%d\n", ret); goto err_clk_put; } } else { - dev_err(&pdev->dev, "no codec-reset GPIO supplied\n"); + ret = ac97->reset_gpio; + dev_err(&pdev->dev, "no codec-reset GPIO supplied: %d\n", ret); goto err_clk_put; } ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node, "nvidia,codec-sync-gpio", 0); if (!gpio_is_valid(ac97->sync_gpio)) { - dev_err(&pdev->dev, "no codec-sync GPIO supplied\n"); + ret = ac97->sync_gpio; + dev_err(&pdev->dev, "no codec-sync GPIO supplied: %d\n", ret); goto err_clk_put; }