| Message ID | 20180807162234.205212-1-mka@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: rt5677: Remove bogus device id from rt5677_of_match | expand |
On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > The initializer of rt5677_of_match contains a bogus device id > (enum type) for the 'type' field (char []). Remove it. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > sound/soc/codecs/rt5677.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c > index 8a0181a2db08..7dab53b35cbf 100644 > --- a/sound/soc/codecs/rt5677.c > +++ b/sound/soc/codecs/rt5677.c > @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = { > }; > > static const struct of_device_id rt5677_of_match[] = { > - { .compatible = "realtek,rt5677", RT5677 }, > + { .compatible = "realtek,rt5677", }, Is that indeed not used, or should it be the following ? ... , .data = RT5677 }, Thanks, Guenter > { } > }; > MODULE_DEVICE_TABLE(of, rt5677_of_match); > -- > 2.18.0.597.ga71716f1ad-goog >
On Tue, Aug 07, 2018 at 09:39:38AM -0700, Guenter Roeck wrote: > On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > The initializer of rt5677_of_match contains a bogus device id > > (enum type) for the 'type' field (char []). Remove it. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > sound/soc/codecs/rt5677.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c > > index 8a0181a2db08..7dab53b35cbf 100644 > > --- a/sound/soc/codecs/rt5677.c > > +++ b/sound/soc/codecs/rt5677.c > > @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = { > > }; > > > > static const struct of_device_id rt5677_of_match[] = { > > - { .compatible = "realtek,rt5677", RT5677 }, > > + { .compatible = "realtek,rt5677", }, > > Is that indeed not used, or should it be the following ? > ... , .data = RT5677 }, You are right, I missed that the driver uses of_device_id->data, will update. Thanks! Matthias
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 8a0181a2db08..7dab53b35cbf 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = { }; static const struct of_device_id rt5677_of_match[] = { - { .compatible = "realtek,rt5677", RT5677 }, + { .compatible = "realtek,rt5677", }, { } }; MODULE_DEVICE_TABLE(of, rt5677_of_match);
The initializer of rt5677_of_match contains a bogus device id (enum type) for the 'type' field (char []). Remove it. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)