From patchwork Tue Sep 18 19:12:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10604827 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3722F6CB for ; Tue, 18 Sep 2018 19:50:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 285262BC05 for ; Tue, 18 Sep 2018 19:50:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1CAA02BD1B; Tue, 18 Sep 2018 19:50:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6EA1A2BD15 for ; Tue, 18 Sep 2018 19:50:47 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4A68E2678AB; Tue, 18 Sep 2018 21:12:45 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3AA432678B3; Tue, 18 Sep 2018 21:12:43 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by alsa0.perex.cz (Postfix) with ESMTP id 374602678AD for ; Tue, 18 Sep 2018 21:12:39 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id k21-v6so1455959pff.11 for ; Tue, 18 Sep 2018 12:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=WQ7uc8QWGGpUa/KSmiOUSgVzUK79FikiAbcCtPnd3Jk=; b=KWZOzPpxBN5FUqHV7N8wPBqKBsQbI6UJ+QdC8c4ilFkdB6c80GxQs3y6Alp2tmi6TK 8e1EbDJGPx2PyQf5QyIvUXTbhAjMajXyDrDUzvI/02dj5+lkzf+GhLMzaqzfHuYzbmyc OmMD5cgJcWGnS8NdCayTUWQxBSyL2HQPfvL7M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WQ7uc8QWGGpUa/KSmiOUSgVzUK79FikiAbcCtPnd3Jk=; b=eaXCXVi5Y4MOobb1RxNf2l1pNCslcFe82X8nUXfrHr/0gLBzGzXbhP2JoOYI3ap4EF do3rkgnYJiE8Z4MTBbWLHZjZhd8m5xHG7PixWhjVxqVMmXjByQBJUUnnTHv3yjM1eOKD M011bpCv5jCcnr4RI/Uug5Q1N4DNSqi5kpyf9I633e/2bPqsUWZVHnPt6zbxmLkepuFJ 7Gax6qlKYu7bmsvA2zLAtsdr88P4mJ5HeqopLubPwZGudofDWQ7m+eGsShznJopS0Bha lZC+o1PlLGhmQvCrdDRnRhHnu26kMWAGA3cAplPEawA+vnYi+PzJ3bphGpjeDbgYOUj4 6jCA== X-Gm-Message-State: APzg51DEbxwwFE3ntM43VNRWyG7ZkGdHtZUXuIeKRPSf5dr7miBmOHLV FtULF3w5wa16HPPoFpvmk5brbQ== X-Google-Smtp-Source: ANB0VdZM7RFAnJYKkZL1v/C4SQk/2x8qZqRungU1dclaQLTHohAeleux72gzcI9D09CfMHLE2kOQJA== X-Received: by 2002:a62:9101:: with SMTP id l1-v6mr32211921pfe.226.1537297958472; Tue, 18 Sep 2018 12:12:38 -0700 (PDT) Received: from localhost.localdomain ([209.121.128.187]) by smtp.gmail.com with ESMTPSA id s73-v6sm34113770pfi.154.2018.09.18.12.12.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 12:12:37 -0700 (PDT) From: Linus Walleij To: Liam Girdwood , Mark Brown Date: Tue, 18 Sep 2018 12:12:33 -0700 Message-Id: <20180918191233.17178-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.1 Cc: alsa-devel@alsa-project.org, Linus Walleij Subject: [alsa-devel] [PATCH 2/2] sound: soc: wm8903: Cut gpio_base data X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This variable is only used inside the file, and we should never hard-code the GPIO base, so delete this. Signed-off-by: Linus Walleij --- sound/soc/codecs/wm8903.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 23e43ff40ded..545512dc4c45 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -144,7 +144,6 @@ struct wm8903_platform_data { int micdet_delay; /* Delay after microphone detection (ms) */ - int gpio_base; u32 gpio_cfg[WM8903_NUM_GPIO]; /* Default register values for GPIO pin mux */ }; @@ -1876,17 +1875,12 @@ static const struct gpio_chip wm8903_template_chip = { static void wm8903_init_gpio(struct wm8903_priv *wm8903) { - struct wm8903_platform_data *pdata = wm8903->pdata; int ret; wm8903->gpio_chip = wm8903_template_chip; wm8903->gpio_chip.ngpio = WM8903_NUM_GPIO; wm8903->gpio_chip.parent = wm8903->dev; - - if (pdata->gpio_base) - wm8903->gpio_chip.base = pdata->gpio_base; - else - wm8903->gpio_chip.base = -1; + wm8903->gpio_chip.base = -1; ret = gpiochip_add_data(&wm8903->gpio_chip, wm8903); if (ret != 0)