| Message ID | 20190118090656.14201-1-stefan@agner.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails | expand |
Hi Stefan, On Fri, Jan 18, 2019 at 7:07 AM Stefan Agner <stefan@agner.ch> wrote: > > Make sure to properly put the of node in case finding the codec > fails. > > Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000io clock support for imx-sgtl5000") > Signed-off-by: Stefan Agner <stefan@agner.ch> > Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> > Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Thanks for the re-ordering: Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index c29200cf755a..594bde3b0ded 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -111,7 +111,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) codec_dev = of_find_i2c_device_by_node(codec_np); if (!codec_dev) { dev_err(&pdev->dev, "failed to find codec platform device\n"); - return -EPROBE_DEFER; + ret = -EPROBE_DEFER; + goto fail; } data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
Make sure to properly put the of node in case finding the codec fails. Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000") Signed-off-by: Stefan Agner <stefan@agner.ch> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> --- Changes in v2: - Reordered patches, make sure this is the first in the patchset -- Stefan sound/soc/fsl/imx-sgtl5000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)