From patchwork Fri Jan 18 09:06:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 10769581 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8BA71186E for ; Fri, 18 Jan 2019 09:13:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79FF42D487 for ; Fri, 18 Jan 2019 09:13:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E76A2D489; Fri, 18 Jan 2019 09:13:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D1A62D490 for ; Fri, 18 Jan 2019 09:13:38 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C618E267263; Fri, 18 Jan 2019 10:07:10 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8D6552670C7; Fri, 18 Jan 2019 10:07:04 +0100 (CET) Received: from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109]) by alsa0.perex.cz (Postfix) with ESMTP id 5A6502670C9 for ; Fri, 18 Jan 2019 10:07:00 +0100 (CET) Received: from trochilidae.toradex.int (unknown [46.140.72.82]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 057B15C2728; Fri, 18 Jan 2019 10:07:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1547802420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PWO+y2NvmzDII8V5/g3zFJFn40YzrEFkPqtfEP5PK+o=; b=eV2Kt+jArqwUBZ/NcPHweYVDbnwMcckTc4FRNaLU0ecIYUI8Wz0Kv/j04ScMQ2G1uCaNjO sWyjbRZj+MuA9zIl7dFrFGAiA+LWrmS2/P3D/S3u3NAcVHu5Udk60syWZcb/N90RJpTeUw ME/CRj+7RaCbo60qVUPYreTjyCbYdjw= From: Stefan Agner To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com Date: Fri, 18 Jan 2019 10:06:56 +0100 Message-Id: <20190118090656.14201-5-stefan@agner.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190118090656.14201-1-stefan@agner.ch> References: <20190118090656.14201-1-stefan@agner.ch> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, Stefan Agner , lgirdwood@gmail.com, broonie@kernel.org, fabio.estevam@nxp.com, Daniel Baluta Subject: [alsa-devel] [PATCH v2 5/5] ASoC: imx-spdif: don't print EPROBE_DEFER as error X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Probe deferral is to be expected during normal operation, so avoid printing an error when it is encountered. Removing the goto would not be strictly necessary. However, if code gets added later, the cleanup in the EPROBE_DEFER case likely would get missed. Signed-off-by: Stefan Agner Reviewed-by: Daniel Baluta Acked-by: Nicolin Chen Reviewed-by: Fabio Estevam --- sound/soc/fsl/imx-spdif.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c index fb896b2c9ba3..797d66e43d49 100644 --- a/sound/soc/fsl/imx-spdif.c +++ b/sound/soc/fsl/imx-spdif.c @@ -67,10 +67,8 @@ static int imx_spdif_audio_probe(struct platform_device *pdev) goto end; ret = devm_snd_soc_register_card(&pdev->dev, &data->card); - if (ret) { + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card failed: %d\n", ret); - goto end; - } end: of_node_put(spdif_np);