| Message ID | 20190213062956.146536-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a4cbb465bcc98f1c5740c887d4be3a68f1a47279 |
| Headers | show |
| Series | [-next] ASoC: cros_ec_codec: Make symbol 'cros_ec_dai' static | expand |
On Wed, Feb 13, 2019 at 2:16 PM Wei Yongjun <weiyongjun1@huawei.com> wrote: > > Fixes the following sparse warning: > > sound/soc/codecs/cros_ec_codec.c:209:27: warning: > symbol 'cros_ec_dai' was not declared. Should it be static? > > Fixes: b291f42a3718 ("ASoC: cros_ec_codec: Add codec driver for Cros EC") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > sound/soc/codecs/cros_ec_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c > index b14100b6a939..99a3af8a15ff 100644 > --- a/sound/soc/codecs/cros_ec_codec.c > +++ b/sound/soc/codecs/cros_ec_codec.c > @@ -206,7 +206,7 @@ static const struct snd_soc_dai_ops cros_ec_i2s_dai_ops = { > .set_fmt = cros_ec_i2s_set_dai_fmt, > }; > > -struct snd_soc_dai_driver cros_ec_dai[] = { > +static struct snd_soc_dai_driver cros_ec_dai[] = { > { > .name = "cros_ec_codec I2S", > .id = 0, > > > Hi Wei, Yes you are right. Thanks for the fix!
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c index b14100b6a939..99a3af8a15ff 100644 --- a/sound/soc/codecs/cros_ec_codec.c +++ b/sound/soc/codecs/cros_ec_codec.c @@ -206,7 +206,7 @@ static const struct snd_soc_dai_ops cros_ec_i2s_dai_ops = { .set_fmt = cros_ec_i2s_set_dai_fmt, }; -struct snd_soc_dai_driver cros_ec_dai[] = { +static struct snd_soc_dai_driver cros_ec_dai[] = { { .name = "cros_ec_codec I2S", .id = 0,
Fixes the following sparse warning: sound/soc/codecs/cros_ec_codec.c:209:27: warning: symbol 'cros_ec_dai' was not declared. Should it be static? Fixes: b291f42a3718 ("ASoC: cros_ec_codec: Add codec driver for Cros EC") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- sound/soc/codecs/cros_ec_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)