From patchwork Fri Mar 8 16:09:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 10845095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5692614E1 for ; Fri, 8 Mar 2019 16:10:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C3832FC15 for ; Fri, 8 Mar 2019 16:10:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37DFC2FC35; Fri, 8 Mar 2019 16:10:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 114D82FC15 for ; Fri, 8 Mar 2019 16:10:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 79C6E85A; Fri, 8 Mar 2019 17:10:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 79C6E85A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1552061454; bh=a0f1NWdNVAUk2opJRZH54F6jL7jbRZE/6tkLedyWIvI=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=A9w3qgLANvqyjEJrj77F4BsLKfuXdnv19g/JR34M+PA+8zCPTgyAfYV55i76CK3pC AHpZk9izbGKJQ6aWCjmNlXxqCyMVGzTKjsan8Fc/NqQ/uMyxSSCVznQVjeFOOMgbCu 4eIpFH0e7jXd25CvKLePyubqrLInVIoZ09S/JnLg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9A634F8072E; Fri, 8 Mar 2019 17:10:03 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id DDA70F896ED; Fri, 8 Mar 2019 17:10:01 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E7B17F8072E for ; Fri, 8 Mar 2019 17:09:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E7B17F8072E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="Ug+6xfU6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ux24lad/zCdpJy8ibmlBBB6mcTMqq0RqLeKynZ+7CTY=; b=Ug+6xfU6cysHmy90PclcPV07ANpLPiuPWtOwunctqtsnROsCABaPJbxiLQUfiLk5QaVozub4YJ+piICoscditf6ZnfPMeK4A163UwlWwBcZE5T4q7/EDCKyvo8D6KNmlwi5f8RUTkofFN9sFIOMSMbd88JDsVZXwmfXR/4kVh20= Received: from VI1PR0402MB3357.eurprd04.prod.outlook.com (52.134.1.18) by VI1PR0402MB2944.eurprd04.prod.outlook.com (10.175.24.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Fri, 8 Mar 2019 16:09:53 +0000 Received: from VI1PR0402MB3357.eurprd04.prod.outlook.com ([fe80::f80e:d03f:57bc:aced]) by VI1PR0402MB3357.eurprd04.prod.outlook.com ([fe80::f80e:d03f:57bc:aced%2]) with mapi id 15.20.1686.019; Fri, 8 Mar 2019 16:09:53 +0000 From: Daniel Baluta To: "broonie@kernel.org" Thread-Topic: [PATCH] ASoC: fsl: sai: Reduce underrun when stream starts Thread-Index: AQHU1cldwQAZkpsXykybw4e/cTic5A== Date: Fri, 8 Mar 2019 16:09:53 +0000 Message-ID: <20190308160933.29899-1-daniel.baluta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR08CA0033.eurprd08.prod.outlook.com (2603:10a6:20b:c0::21) To VI1PR0402MB3357.eurprd04.prod.outlook.com (2603:10a6:803:2::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniel.baluta@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.76.156.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 192cbf23-15c9-4581-e09b-08d6a3e07fef x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB2944; x-ms-traffictypediagnostic: VI1PR0402MB2944: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; VI1PR0402MB2944; 23:G9m65UK4bGRrvGVns9RGlmg8v+oSxTLMebEbI?= =?iso-8859-1?q?ykrupHkfFIQjeDnYt?= =?iso-8859-1?q?6RmFWRrba6T4/E6UE5ODd7BsXxUqxf7Jv8x2Gys01g90rFrlmhOoz0DtgDpq?= =?iso-8859-1?q?y7dr3IXyr2ELVCIm5uyWF/4oJ0nI+DypPkMRubf3wuxcSTVro9cwQbaRdTon?= =?iso-8859-1?q?W4/0hynrtKc0Wn6HcymQLaatAFvPdPI4hOq3aUPE0u730uhAXkfJj+ftTQhf?= =?iso-8859-1?q?dRX9+Vh5FGAq3UMQHvSrFUL+vVUbbi+xPsIg9MThe2IQhDw7KY7hgtnKnASP?= =?iso-8859-1?q?CNl1ftICt9DI37V17XMQIpYxmdI/6isA2xpNW3p72VnB5rSQ4Js1U6Tw01rx?= =?iso-8859-1?q?h69rdHLn4M6WzimqeTMBgTXV0TRtc0q59WZgxUb6MW5gRxfimshRuQaKw9j3?= =?iso-8859-1?q?mPxxVXiH11OtlJ/A4x19QBZjTZVSmqAqY/x2rD98Avx9CuTH9GrV38ZLap6x?= =?iso-8859-1?q?r+WTUdNO2IPKL6aXqzsXsvgle+7+4bo45P5A9zgkQb5DX2XZ49sU9bMV7kW0?= =?iso-8859-1?q?/mz2c4CLtLMinFZTOYrYZcOA8V/GBovCvs1n4dKABjzfRjfobxljbk0qImdi?= =?iso-8859-1?q?1zcHcUVASrNpNlip6fvb4O38W2ycXE0I9qgO7/jKR6VGiMwIgm8gcRW5Fvge?= =?iso-8859-1?q?gDaUQOzrGzeLRGZRWkImJY8zN1/epBKnZXT7BRn2Y3SjmirBtE/I3eOAW3Wl?= =?iso-8859-1?q?mLEgnqCeCf8XyoGwfD/jOnFe45Jc7KVi6SmxOb6dIO+eZ+YsUztmqPMQ5tre?= =?iso-8859-1?q?Si7Gc7YmM4N9FB07QZylqdhR0Ox2v/z+wt1BkGIKvggPvjRRjYMCyMocIb7/?= =?iso-8859-1?q?Tn9NEkYGfvlCTyhEp48uyLUUAkqSeUuD70ZHaWfGRMQColE+uBvXoVmG5NMF?= =?iso-8859-1?q?MOl5P3HWIPS2e50JBYDG1+Y8pz9NR/70Nn1ijl+yV3Iq/APvk5U2lRNc5Y/m?= =?iso-8859-1?q?Cbe4//0wPW1WH5Df6DkzBzO77nLT3gP+T+vF1Di2uIpcFjWy3w6neFpAhvGe?= =?iso-8859-1?q?pH83hVvx8iRrlpnAnQYrZsWf6w6YEpuWcmJXZA8krmXSLoz+l+tqU16kg+bP?= =?iso-8859-1?q?HTqxdUjPKWc/Y/BQmMiDNus9SvbmeBA1qyy6QXJdl/WJdo1Hb8HT3pONiZ3D?= =?iso-8859-1?q?VX55AduFAIsbDEe8p+MFm56Zf7b2Rx2xOJB5IStVXqJL9C4/G9/aMl2alggW?= =?iso-8859-1?q?PLUVQIIK7+tz6xEG3RUqczSbB9NeQo1jJq7Fn5Km9RuSk80fzWDpFSKCgNK7?= =?iso-8859-1?q?sRmGFVe+VXSfJYnrQqdQ3q2wlU?= x-microsoft-antispam-prvs: x-forefront-prvs: 0970508454 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(366004)(376002)(396003)(199004)(189003)(6486002)(3846002)(25786009)(5640700003)(6512007)(4326008)(6436002)(53936002)(186003)(54906003)(36756003)(50226002)(2906002)(14454004)(256004)(68736007)(14444005)(66066001)(7736002)(305945005)(102836004)(316002)(2501003)(71190400001)(71200400001)(486006)(1730700003)(81166006)(386003)(478600001)(8676002)(86362001)(6916009)(6506007)(26005)(44832011)(476003)(2616005)(99286004)(2351001)(81156014)(105586002)(1076003)(52116002)(106356001)(97736004)(6116002)(5660300002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB2944; H:VI1PR0402MB3357.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FOjAFB2qXz/p+oEv6GXeF/3DcjXa/rpgxQZHeC64VCTGFNQzCeln4H/uW/mnx0E1ylqh5TaIKkUwmBMaS1qrLTdP/yHnr3FtHk9vYFug/Tng5Lf49CFhE2ioGz3mnj5nAZE1VSPAtSbIVPzFeccLUaeEZkInkuVE3i9VOUuPWRONMvYGhB1stL9o6vsstyoEz+Ou0VpOitld6QktGF7I/n8fwaU7xGYXVUESZBoH/L1ObHqrYNYWuq4euAOcZGxeIA2mgQhjo3oboXoC8UMPeAiH8XPdtKb7Wi3u5PWizBKv1ih0e/Tfu4/Wy7wHnkQIpd7l5J3NTMuwQEmXVfcINq9PVsE4BloLN2zYOlSTVud59y4i82QV630+AdCpapaFMwI8JIbc58qR55G3SluRphsy8ZqS2nE7zVP2e/OOyps= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 192cbf23-15c9-4581-e09b-08d6a3e07fef X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2019 16:09:53.7164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2944 Cc: "alsa-devel@alsa-project.org" , "Xiubo.Lee@gmail.com" , Daniel Baluta , "S.j. Wang" , "tiwai@suse.com" , "linux-kernel@vger.kernel.org" , "nicoleotsuka@gmail.com" , dl-linux-imx , "festevam@gmail.com" Subject: [alsa-devel] [PATCH] ASoC: fsl: sai: Reduce underrun when stream starts X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Shengjiu Wang Write initial words into SAI FIFO to reduce the underrun error. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index db9e0872f73d..99edbba4e8fa 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -503,7 +503,9 @@ static int fsl_sai_trigger(struct snd_pcm_substream *substream, int cmd, { struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; + unsigned int channels = substream->runtime->channels; u32 xcsr, count = 100; + int i; /* * Asynchronous mode: Clear SYNC for both Tx and Rx. @@ -526,6 +528,11 @@ static int fsl_sai_trigger(struct snd_pcm_substream *substream, int cmd, regmap_update_bits(sai->regmap, FSL_SAI_xCSR(tx), FSL_SAI_CSR_FRDE, FSL_SAI_CSR_FRDE); + for (i = 0; tx && i < channels; i++) + regmap_write(sai->regmap, FSL_SAI_TDR, 0x0); + if (tx) + udelay(10); + regmap_update_bits(sai->regmap, FSL_SAI_RCSR, FSL_SAI_CSR_TERE, FSL_SAI_CSR_TERE); regmap_update_bits(sai->regmap, FSL_SAI_TCSR,