| Message ID | 20190625074937.2621-2-oleksandr.suvorov@toradex.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | VAG power control improvement for sgtl5000 codec | expand |
On Tue, Jun 25, 2019 at 10:55 AM Oleksandr Suvorov <oleksandr.suvorov@toradex.com> wrote: > > SGTL5000_SMALL_POP is a bit mask, not a value. Usage of > correct definition makes device probing code more clear. > > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> > --- > > sound/soc/codecs/sgtl5000.c | 2 +- > sound/soc/codecs/sgtl5000.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > index a6a4748c97f9d..5e49523ee0b67 100644 > --- a/sound/soc/codecs/sgtl5000.c > +++ b/sound/soc/codecs/sgtl5000.c > @@ -1296,7 +1296,7 @@ static int sgtl5000_probe(struct snd_soc_component *component) > > /* enable small pop, introduce 400ms delay in turning off */ > snd_soc_component_update_bits(component, SGTL5000_CHIP_REF_CTRL, > - SGTL5000_SMALL_POP, 1); > + SGTL5000_SMALL_POP, SGTL5000_SMALL_POP); > > /* disable short cut detector */ > snd_soc_component_write(component, SGTL5000_CHIP_SHORT_CTRL, 0); > diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h > index 18cae08bbd3a6..a4bf4bca95bf7 100644 > --- a/sound/soc/codecs/sgtl5000.h > +++ b/sound/soc/codecs/sgtl5000.h > @@ -273,7 +273,7 @@ > #define SGTL5000_BIAS_CTRL_MASK 0x000e > #define SGTL5000_BIAS_CTRL_SHIFT 1 > #define SGTL5000_BIAS_CTRL_WIDTH 3 > -#define SGTL5000_SMALL_POP 1 > +#define SGTL5000_SMALL_POP 0x0001 > > /* > * SGTL5000_CHIP_MIC_CTRL > -- > 2.20.1 > Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index a6a4748c97f9d..5e49523ee0b67 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1296,7 +1296,7 @@ static int sgtl5000_probe(struct snd_soc_component *component) /* enable small pop, introduce 400ms delay in turning off */ snd_soc_component_update_bits(component, SGTL5000_CHIP_REF_CTRL, - SGTL5000_SMALL_POP, 1); + SGTL5000_SMALL_POP, SGTL5000_SMALL_POP); /* disable short cut detector */ snd_soc_component_write(component, SGTL5000_CHIP_SHORT_CTRL, 0); diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index 18cae08bbd3a6..a4bf4bca95bf7 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -273,7 +273,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 1 +#define SGTL5000_SMALL_POP 0x0001 /* * SGTL5000_CHIP_MIC_CTRL
SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com> --- sound/soc/codecs/sgtl5000.c | 2 +- sound/soc/codecs/sgtl5000.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)