diff mbox series

[3/3] ASoC: rt1308: Convert headers to SPDX

Message ID 20190719063302.18858-1-shumingf@realtek.com (mailing list archive)
State New, archived
Headers show
Series [1/3] ASoC: rt1308: simplify the EFUSE read function | expand

Commit Message

Shuming [范書銘] July 19, 2019, 6:33 a.m. UTC 
From: Shuming Fan <shumingf@realtek.com>

Convert include and source files to SPDX.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
 sound/soc/codecs/rt1308.c | 4 +---
 sound/soc/codecs/rt1308.h | 6 ++----
 2 files changed, 3 insertions(+), 7 deletions(-)

Comments

Mark Brown July 19, 2019, 4:46 p.m. UTC | #1 
On Fri, Jul 19, 2019 at 02:33:02PM +0800, shumingf@realtek.com wrote:

> @@ -1,12 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
>   *

Please convert the entire comment block to a C++ one so this looks more
intentional.
Mark Brown July 22, 2019, 10:58 a.m. UTC | #2 
On Mon, Jul 22, 2019 at 02:07:47AM +0000, Shuming [范書銘] wrote:
> > On Fri, Jul 19, 2019 at 02:33:02PM +0800, shumingf@realtek.com wrote:

> > > @@ -1,12 +1,10 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > >  /*
> > >   * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
> > >   *

> > Please convert the entire comment block to a C++ one so this looks more
> > intentional.

> I convert the comment like below.
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */

That's a C comment, not a C++ comment.  I'm saying convert the whole
block there to C++ rather than add one random line that's C++ next to
some C comments.
Shuming [范書銘] July 22, 2019, 11:48 a.m. UTC | #3 
> On Mon, Jul 22, 2019 at 02:07:47AM +0000, Shuming [范書銘] wrote:
> > > On Fri, Jul 19, 2019 at 02:33:02PM +0800, shumingf@realtek.com wrote:
> 
> > > > @@ -1,12 +1,10 @@
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > >  /*
> > > >   * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
> > > >   *
> 
> > > Please convert the entire comment block to a C++ one so this looks
> > > more intentional.
> 
> > I convert the comment like below.
> > -// SPDX-License-Identifier: GPL-2.0
> > +/* SPDX-License-Identifier: GPL-2.0 */
> 
> That's a C comment, not a C++ comment.  I'm saying convert the whole block
> there to C++ rather than add one random line that's C++ next to some C
> comments.
> 

May I confirm what your point?
I convert the entire comment block to a C++ one like below.
// SPDX-License-Identifier: GPL-2.0
-/*
- * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
- *
- * Copyright 2019 Realtek Semiconductor Corp.
- * Author: Derek Fang <derek.fang@realtek.com>
- *
- */
+//
+// rt1308.c  --  RT1308 ALSA SoC amplifier component driver
+//
+// Copyright 2019 Realtek Semiconductor Corp.
+// Author: Derek Fang <derek.fang@realtek.com>
+//
Mark Brown July 22, 2019, 11:50 a.m. UTC | #4 
On Mon, Jul 22, 2019 at 11:48:52AM +0000, Shuming [范書銘] wrote:


> May I confirm what your point?
> I convert the entire comment block to a C++ one like below.
> // SPDX-License-Identifier: GPL-2.0
> -/*
> - * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
> - *
> - * Copyright 2019 Realtek Semiconductor Corp.
> - * Author: Derek Fang <derek.fang@realtek.com>
> - *
> - */
> +//
> +// rt1308.c  --  RT1308 ALSA SoC amplifier component driver
> +//
> +// Copyright 2019 Realtek Semiconductor Corp.
> +// Author: Derek Fang <derek.fang@realtek.com>
> +//

Yes.
Shuming [范書銘] July 22, 2019, 11:55 a.m. UTC | #5 
> On Mon, Jul 22, 2019 at 11:48:52AM +0000, Shuming [范書銘] wrote:
> 
> 
> > May I confirm what your point?
> > I convert the entire comment block to a C++ one like below.
> > // SPDX-License-Identifier: GPL-2.0
> > -/*
> > - * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
> > - *
> > - * Copyright 2019 Realtek Semiconductor Corp.
> > - * Author: Derek Fang <derek.fang@realtek.com>
> > - *
> > - */
> > +//
> > +// rt1308.c  --  RT1308 ALSA SoC amplifier component driver // //
> > +Copyright 2019 Realtek Semiconductor Corp.
> > +// Author: Derek Fang <derek.fang@realtek.com> //
> 
> Yes.
> 

Ok, I will send the second version for these patches.
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt1308.c b/sound/soc/codecs/rt1308.c
index cf3d72f99705..694ea22f25a8 100644
--- a/sound/soc/codecs/rt1308.c
+++ b/sound/soc/codecs/rt1308.c
@@ -1,12 +1,10 @@ 
+// SPDX-License-Identifier: GPL-2.0
 /*
  * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
  *
  * Copyright 2019 Realtek Semiconductor Corp.
  * Author: Derek Fang <derek.fang@realtek.com>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 
 #include <linux/module.h>
diff --git a/sound/soc/codecs/rt1308.h b/sound/soc/codecs/rt1308.h
index c330aae1d527..ff7c423e879e 100644
--- a/sound/soc/codecs/rt1308.h
+++ b/sound/soc/codecs/rt1308.h
@@ -1,12 +1,10 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
- * RT1308.h  --  RT1308 ALSA SoC amplifier component driver
+ * rt1308.h  --  RT1308 ALSA SoC amplifier component driver
  *
  * Copyright 2019 Realtek Semiconductor Corp.
  * Author: Derek Fang <derek.fang@realtek.com>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 
 #ifndef _RT1308_H_