diff mbox series

ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create()

Message ID 20190925110624.GR3264@mwanda (mailing list archive)
State Accepted
Commit 752c938a5c14b8cbf0ed3ffbfa637fb166255c3f
Headers show
Series ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create() | expand

Commit Message

Dan Carpenter Sept. 25, 2019, 11:06 a.m. UTC 
The "template.id" variable is an enum and in this context GCC will
treat it as an unsigned int so it can never be less than zero.

Fixes: 8a9782346dcc ("ASoC: topology: Add topology core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/soc-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index aa9a1fca46fa..0fd032914a31 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -1582,7 +1582,7 @@  static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
 
 	/* map user to kernel widget ID */
 	template.id = get_widget_id(le32_to_cpu(w->id));
-	if (template.id < 0)
+	if ((int)template.id < 0)
 		return template.id;
 
 	/* strings are allocated here, but used and freed by the widget */