diff mbox series

ASoC: wm_adsp: Don't generate kcontrols without READ flags

Message ID 20191002084240.21589-1-ckeepax@opensource.cirrus.com (mailing list archive)
State Accepted
Commit 3ae7359c0e39f42a96284d6798fc669acff38140
Headers show
Series ASoC: wm_adsp: Don't generate kcontrols without READ flags | expand

Commit Message

Charles Keepax Oct. 2, 2019, 8:42 a.m. UTC 
From: Stuart Henderson <stuarth@opensource.cirrus.com>

User space always expects to be able to read ALSA controls, so ensure
no kcontrols are generated without an appropriate READ flag. In the case
of a read of such a control zeros will be returned.

Signed-off-by: Stuart Henderson <stuarth@opensource.cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 sound/soc/codecs/wm_adsp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 85396d920e0a9..9b8bb7bbe945d 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1259,8 +1259,7 @@  static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len)
 	}
 
 	if (in) {
-		if (in & WMFW_CTL_FLAG_READABLE)
-			out |= rd;
+		out |= rd;
 		if (in & WMFW_CTL_FLAG_WRITEABLE)
 			out |= wr;
 		if (in & WMFW_CTL_FLAG_VOLATILE)