| Message ID | 20200210093027.6672-1-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0d4416446897a91bb19ba837b97b607caea59a8f |
| Headers | show |
| Series | spi: pxa2xx: Enable support for compile-testing | expand |
On 2/10/20 3:30 AM, Geert Uytterhoeven wrote: > m68k/allmodconfig: > > WARNING: unmet direct dependencies detected for SPI_PXA2XX > Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PXA || ARCH_MMP || PCI [=n] || ACPI) > Selected by [m]: > - SND_SOC_INTEL_BDW_RT5677_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_INTEL_HASWELL [=n] || SND_SOC_SOF_BROADWELL [=m]) && I2C [=m] && (I2C_DESIGNWARE_PLATFORM [=m] || COMPILE_TEST [=y]) && (GPIOLIB [=y] || COMPILE_TEST [=y]) && (X86_INTEL_LPSS || COMPILE_TEST [=y]) && SPI_MASTER [=y] > > This happens because SND_SOC_INTEL_BDW_RT5677_MACH selects SPI_PXA2XX, > and the former depends on COMPILE_TEST, while the latter does not. > > Fix this by enabling compile-testing for SPI_PXA2XX. > > Fixes: 630db1549356f644 ("ASoC: Intel: bdw-rt5677: fix Kconfig dependencies") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Makes sense. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index ee96708aa3a77156..2e1c3a575f7a6cc3 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -557,7 +557,7 @@ config SPI_PPC4xx > > config SPI_PXA2XX > tristate "PXA2xx SSP SPI master" > - depends on (ARCH_PXA || ARCH_MMP || PCI || ACPI) > + depends on ARCH_PXA || ARCH_MMP || PCI || ACPI || COMPILE_TEST > select PXA_SSP if ARCH_PXA || ARCH_MMP > help > This enables using a PXA2xx or Sodaville SSP port as a SPI master >
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index ee96708aa3a77156..2e1c3a575f7a6cc3 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -557,7 +557,7 @@ config SPI_PPC4xx config SPI_PXA2XX tristate "PXA2xx SSP SPI master" - depends on (ARCH_PXA || ARCH_MMP || PCI || ACPI) + depends on ARCH_PXA || ARCH_MMP || PCI || ACPI || COMPILE_TEST select PXA_SSP if ARCH_PXA || ARCH_MMP help This enables using a PXA2xx or Sodaville SSP port as a SPI master
m68k/allmodconfig: WARNING: unmet direct dependencies detected for SPI_PXA2XX Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PXA || ARCH_MMP || PCI [=n] || ACPI) Selected by [m]: - SND_SOC_INTEL_BDW_RT5677_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_INTEL_HASWELL [=n] || SND_SOC_SOF_BROADWELL [=m]) && I2C [=m] && (I2C_DESIGNWARE_PLATFORM [=m] || COMPILE_TEST [=y]) && (GPIOLIB [=y] || COMPILE_TEST [=y]) && (X86_INTEL_LPSS || COMPILE_TEST [=y]) && SPI_MASTER [=y] This happens because SND_SOC_INTEL_BDW_RT5677_MACH selects SPI_PXA2XX, and the former depends on COMPILE_TEST, while the latter does not. Fix this by enabling compile-testing for SPI_PXA2XX. Fixes: 630db1549356f644 ("ASoC: Intel: bdw-rt5677: fix Kconfig dependencies") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)