| Message ID | 20200313180543.20497-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example | expand |
On Fri, Mar 13, 2020 at 01:05:43PM -0500, Rob Herring wrote: > Extra dtc warnings (roughly what W=1 enables) are now enabled by default > when building the binding examples. These were fixed treewide in > 5.6-rc5, but the newly added google,cros-ec-codec schema adds some new > warnings: v1 got applied, could you send an incremental diff please?
On Fri, Mar 13, 2020 at 1:55 PM Mark Brown <broonie@kernel.org> wrote: > > On Fri, Mar 13, 2020 at 01:05:43PM -0500, Rob Herring wrote: > > Extra dtc warnings (roughly what W=1 enables) are now enabled by default > > when building the binding examples. These were fixed treewide in > > 5.6-rc5, but the newly added google,cros-ec-codec schema adds some new > > warnings: > > v1 got applied, could you send an incremental diff please? Indeed, missed that. While I wish Gmail could just learn to thread emails properly, it would help Gmail users a lot if you kept the $subject on your applied emails. I'll just worry about the node name again when and if we start checking that... Rob
diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml index 94a85d0cbf43..d62284288f23 100644 --- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml @@ -44,19 +44,24 @@ additionalProperties: false examples: - | - reserved_mem: reserved_mem { + reserved_mem: reserved-mem@52800000 { compatible = "shared-dma-pool"; - reg = <0 0x52800000 0 0x100000>; + reg = <0x52800000 0x100000>; no-map; }; - cros-ec@0 { - compatible = "google,cros-ec-spi"; - #address-cells = <2>; - #size-cells = <1>; - cros_ec_codec: ec-codec { - compatible = "google,cros-ec-codec"; - #sound-dai-cells = <1>; - reg = <0x0 0x10500000 0x80000>; - memory-region = <&reserved_mem>; + spi { + #address-cells = <1>; + #size-cells = <0>; + cros-ec@0 { + compatible = "google,cros-ec-spi"; + #address-cells = <2>; + #size-cells = <1>; + reg = <0>; + cros_ec_codec: audio-codec@10500000 { + compatible = "google,cros-ec-codec"; + #sound-dai-cells = <1>; + reg = <0x0 0x10500000 0x80000>; + memory-region = <&reserved_mem>; + }; }; };
Extra dtc warnings (roughly what W=1 enables) are now enabled by default when building the binding examples. These were fixed treewide in 5.6-rc5, but the newly added google,cros-ec-codec schema adds some new warnings: Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11: Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11: Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg property Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15: Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name Fixing the above, then results in: Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23: Warning (reg_format): /example-0/cros-ec@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15: Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name Fix these warnings and adjust the node name to 'audio-codec' while we're touching the node name. Fixes: eadd54c75f1e ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.") Cc: Cheng-Yi Chiang <cychiang@chromium.org> Cc: Guenter Roeck <groeck@chromium.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Benson Leung <bleung@chromium.org> Cc: alsa-devel@alsa-project.org Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - s/ec-codec/audio-codec/ --- .../bindings/sound/google,cros-ec-codec.yaml | 27 +++++++++++-------- 1 file changed, 16 insertions(+), 11 deletions(-)