| Message ID | 20200326172457.205493-1-saravanak@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] slimbus: core: Set fwnode for a device when setting of_node | expand |
On Thu, Mar 26, 2020 at 10:25 AM Saravana Kannan <saravanak@google.com> wrote: > > When setting the of_node for a newly created device, also set the > fwnode. This allows fw_devlink feature to work for slimbus devices. > > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/slimbus/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c > index 526e3215d8fe..44228a5b246d 100644 > --- a/drivers/slimbus/core.c > +++ b/drivers/slimbus/core.c > @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl, > INIT_LIST_HEAD(&sbdev->stream_list); > spin_lock_init(&sbdev->stream_list_lock); > > - if (node) > + if (node) { > sbdev->dev.of_node = of_node_get(node); > + sbdev->dev.fwnode = of_fwnode_handle(node); > + } > > dev_set_name(&sbdev->dev, "%x:%x:%x:%x", > sbdev->e_addr.manf_id, > -- Hi Srinivas, Btw, I sent another patch that's on top of this patch. https://lore.kernel.org/lkml/20200326173457.29233-1-saravanak@google.com/T/#u That fixes of_node_get() handling. Didn't notice it before I sent this patch. Otherwise would have made it a series. Sorry about the trouble. Thanks, Saravana
On Thu, Mar 26, 2020 at 10:25 AM Saravana Kannan <saravanak@google.com> wrote: > > When setting the of_node for a newly created device, also set the > fwnode. This allows fw_devlink feature to work for slimbus devices. > > Signed-off-by: Saravana Kannan <saravanak@google.com> Tested-by: John Stultz <john.stultz@linaro.org> thanks! -john
On 26/03/2020 17:24, Saravana Kannan wrote: > When setting the of_node for a newly created device, also set the > fwnode. This allows fw_devlink feature to work for slimbus devices. > > Signed-off-by: Saravana Kannan <saravanak@google.com> Applied Thanks, --srini > --- > drivers/slimbus/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c > index 526e3215d8fe..44228a5b246d 100644 > --- a/drivers/slimbus/core.c > +++ b/drivers/slimbus/core.c > @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl, > INIT_LIST_HEAD(&sbdev->stream_list); > spin_lock_init(&sbdev->stream_list_lock); > > - if (node) > + if (node) { > sbdev->dev.of_node = of_node_get(node); > + sbdev->dev.fwnode = of_fwnode_handle(node); > + } > > dev_set_name(&sbdev->dev, "%x:%x:%x:%x", > sbdev->e_addr.manf_id, >
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 526e3215d8fe..44228a5b246d 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl, INIT_LIST_HEAD(&sbdev->stream_list); spin_lock_init(&sbdev->stream_list_lock); - if (node) + if (node) { sbdev->dev.of_node = of_node_get(node); + sbdev->dev.fwnode = of_fwnode_handle(node); + } dev_set_name(&sbdev->dev, "%x:%x:%x:%x", sbdev->e_addr.manf_id,
When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink feature to work for slimbus devices. Signed-off-by: Saravana Kannan <saravanak@google.com> --- drivers/slimbus/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)