| Message ID | 20200410115708.27708-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] soundwire: intel: Make sdw_intel_init static | expand |
On 4/10/20 6:57 AM, YueHaibing wrote: > Fix sparse warning: > > drivers/soundwire/intel_init.c:193:6: warning: > symbol 'sdw_intel_init' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/soundwire/intel_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c > index 4b769409f6f8..ad7053463889 100644 > --- a/drivers/soundwire/intel_init.c > +++ b/drivers/soundwire/intel_init.c > @@ -190,7 +190,8 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level, > * This scans the namespace and creates SoundWire link controller devices > * based on the info queried. > */ > -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res) > +static void *sdw_intel_init(acpi_handle *parent_handle, > + struct sdw_intel_res *res) This declaration has been this way since 2017, there are no users and it will be removed with the Intel patchsets, so fixing this warning doesn't really add much value. No sustained objection though. > { > acpi_status status; > >
On 10-04-20, 19:57, YueHaibing wrote: > Fix sparse warning: > > drivers/soundwire/intel_init.c:193:6: warning: > symbol 'sdw_intel_init' was not declared. Should it be static? Applied, thanks
On Mon, Apr 20, 2020 at 12:42:12PM +0530, Vinod Koul wrote: > On 10-04-20, 19:57, YueHaibing wrote: > > Fix sparse warning: > > > > drivers/soundwire/intel_init.c:193:6: warning: > > symbol 'sdw_intel_init' was not declared. Should it be static? > > Applied, thanks > > -- > ~Vinod Why was this applied? It replaces one warning with another (that is actually visible during a normal kernel build): $ make -j$(nproc) -s allyesconfig drivers/soundwire/intel_init.o drivers/soundwire/intel_init.c:193:14: warning: ‘sdw_intel_init’ defined but not used [-Wunused-function] static void *sdw_intel_init(acpi_handle *parent_handle, ^~~~~~~~~~~~~~ Cheers, Nathan
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c index 4b769409f6f8..ad7053463889 100644 --- a/drivers/soundwire/intel_init.c +++ b/drivers/soundwire/intel_init.c @@ -190,7 +190,8 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level, * This scans the namespace and creates SoundWire link controller devices * based on the info queried. */ -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res) +static void *sdw_intel_init(acpi_handle *parent_handle, + struct sdw_intel_res *res) { acpi_status status;
Fix sparse warning: drivers/soundwire/intel_init.c:193:6: warning: symbol 'sdw_intel_init' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/soundwire/intel_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)