| Message ID | 20200422092255.GB195357@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats() | expand |
On Wed, 22 Apr 2020 11:22:55 +0200, Dan Carpenter wrote: > > This should be ARRAY_SIZE() instead of sizeof(). The sizeof() limit is > too high so it doesn't work. > > Fixes: 093b8494f299 ("ALSA: usb-audio: Print more information in stream proc files") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks, applied. Takashi
diff --git a/sound/usb/proc.c b/sound/usb/proc.c index 5a36e192ebb0..889c550c9f29 100644 --- a/sound/usb/proc.c +++ b/sound/usb/proc.c @@ -140,7 +140,7 @@ static void proc_dump_substream_formats(struct snd_usb_substream *subs, struct s snd_iprintf(buffer, " Channel map:"); for (c = 0; c < map->channels; c++) { - if (map->map[c] >= sizeof(channel_labels) || + if (map->map[c] >= ARRAY_SIZE(channel_labels) || !channel_labels[map->map[c]]) snd_iprintf(buffer, " --"); else
This should be ARRAY_SIZE() instead of sizeof(). The sizeof() limit is too high so it doesn't work. Fixes: 093b8494f299 ("ALSA: usb-audio: Print more information in stream proc files") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- sound/usb/proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)