| Message ID | 20200526200917.10385-1-dmurphy@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2465d32bea35d1d56c6cfb08a96ebea3b475d8ec |
| Headers | show |
| Series | [1/2] dt-bindings: sound: tlv320adcx140: Add GPI config property | expand |
On Tue, 26 May 2020 15:09:16 -0500, Dan Murphy wrote: > Add an array property that configures the General Purpose Input (GPI) > register. The device has 4 GPI pins and each pin can be configured in 1 > of 7 different ways. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] dt-bindings: sound: tlv320adcx140: Add GPI config property commit: 2465d32bea35d1d56c6cfb08a96ebea3b475d8ec [2/2] ASoC: tlv320adcx140: Add support for configuring GPI pins commit: 3c35e79cead31c3bd79875ae90f9655dc77ad13c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, May 26, 2020 at 03:09:16PM -0500, Dan Murphy wrote: > Add an array property that configures the General Purpose Input (GPI) > register. The device has 4 GPI pins and each pin can be configured in 1 > of 7 different ways. Dan seems to have trouble running get_maintainers.pl and Cc'ing the DT list. Running 'make dt_binding_check' also seems to be a problem. Now linux-next has these warnings: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/sound/tlv320adcx140.example.dt.yaml: codec@4c: ti,gpi-config:0:0: 4 is greater than the maximum of 1 /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/sound/tlv320adcx140.example.dt.yaml: codec@4c: ti,gpi-config:0:1: 5 is greater than the maximum of 1 /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/sound/tlv320adcx140.example.dt.yaml: codec@4c: ti,gpi-config:0:2: 6 is greater than the maximum of 1 /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/sound/tlv320adcx140.example.dt.yaml: codec@4c: ti,gpi-config:0:3: 7 is greater than the maximum of 1 Please send a fix. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../bindings/sound/tlv320adcx140.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml > index daa6cc0e031b..e8a69b1c7ca9 100644 > --- a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml > +++ b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml > @@ -86,6 +86,32 @@ properties: > maximum: 1 > default: [0, 0, 0, 0] > > + ti,gpi-config: > + description: | > + Defines the configuration for the general purpose input pins (GPI). > + The array is defined as <GPI1 GPI2 GPI3 GPI4>. > + > + 0 - (default) disabled > + 1 - GPIX is configured as a general-purpose input (GPI) > + 2 - GPIX is configured as a master clock input (MCLK) > + 3 - GPIX is configured as an ASI input for daisy-chain (SDIN) > + 4 - GPIX is configured as a PDM data input for channel 1 and channel > + (PDMDIN1) > + 5 - GPIX is configured as a PDM data input for channel 3 and channel > + (PDMDIN2) > + 6 - GPIX is configured as a PDM data input for channel 5 and channel > + (PDMDIN3) > + 7 - GPIX is configured as a PDM data input for channel 7 and channel > + (PDMDIN4) > + > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-array > + - minItems: 1 > + maxItems: 4 > + items: > + maximum: 1 I believe you want '7' here. > + default: [0, 0, 0, 0] > + > required: > - compatible > - reg > @@ -101,6 +127,7 @@ examples: > reg = <0x4c>; > ti,mic-bias-source = <6>; > ti,pdm-edge-select = <0 1 0 1>; > + ti,gpi-config = <4 5 6 7>; > reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; > }; > }; > -- > 2.26.2 >
Rob On 5/28/20 9:05 AM, Rob Herring wrote: > On Tue, May 26, 2020 at 03:09:16PM -0500, Dan Murphy wrote: >> Add an array property that configures the General Purpose Input (GPI) >> register. The device has 4 GPI pins and each pin can be configured in 1 >> of 7 different ways. > Dan seems to have trouble running get_maintainers.pl and Cc'ing the DT > list. Running 'make dt_binding_check' also seems to be a problem. Now > linux-next has these warnings: I don't have an issue with doing get_maintainers. All the maintainers listed were added to the patch. And devicetree@vger.kernel.org was cc'd. I will fix this warning. Dan
On Thu, May 28, 2020 at 8:20 AM Dan Murphy <dmurphy@ti.com> wrote: > > Rob > > On 5/28/20 9:05 AM, Rob Herring wrote: > > On Tue, May 26, 2020 at 03:09:16PM -0500, Dan Murphy wrote: > >> Add an array property that configures the General Purpose Input (GPI) > >> register. The device has 4 GPI pins and each pin can be configured in 1 > >> of 7 different ways. > > Dan seems to have trouble running get_maintainers.pl and Cc'ing the DT > > list. Running 'make dt_binding_check' also seems to be a problem. Now > > linux-next has these warnings: > > I don't have an issue with doing get_maintainers. All the maintainers > listed were added to the patch. > > And devicetree@vger.kernel.org was cc'd. Indeed, sorry for my rant. Some reason my search didn't find it. Not sure why my tester didn't flag this either... Rob
diff --git a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml index daa6cc0e031b..e8a69b1c7ca9 100644 --- a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml +++ b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml @@ -86,6 +86,32 @@ properties: maximum: 1 default: [0, 0, 0, 0] + ti,gpi-config: + description: | + Defines the configuration for the general purpose input pins (GPI). + The array is defined as <GPI1 GPI2 GPI3 GPI4>. + + 0 - (default) disabled + 1 - GPIX is configured as a general-purpose input (GPI) + 2 - GPIX is configured as a master clock input (MCLK) + 3 - GPIX is configured as an ASI input for daisy-chain (SDIN) + 4 - GPIX is configured as a PDM data input for channel 1 and channel + (PDMDIN1) + 5 - GPIX is configured as a PDM data input for channel 3 and channel + (PDMDIN2) + 6 - GPIX is configured as a PDM data input for channel 5 and channel + (PDMDIN3) + 7 - GPIX is configured as a PDM data input for channel 7 and channel + (PDMDIN4) + + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + - minItems: 1 + maxItems: 4 + items: + maximum: 1 + default: [0, 0, 0, 0] + required: - compatible - reg @@ -101,6 +127,7 @@ examples: reg = <0x4c>; ti,mic-bias-source = <6>; ti,pdm-edge-select = <0 1 0 1>; + ti,gpi-config = <4 5 6 7>; reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; }; };
Add an array property that configures the General Purpose Input (GPI) register. The device has 4 GPI pins and each pin can be configured in 1 of 7 different ways. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- .../bindings/sound/tlv320adcx140.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+)