| Message ID | 20200717081710.39180-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] ALSA: line6: Use kmemdup in podhd_set_monitor_level() | expand |
On Fri, 17 Jul 2020 10:17:10 +0200, YueHaibing wrote: > > Use kmemdup rather than duplicating its implementation. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied now. Thanks. Takashi
diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c index 1557483ec657..eef45f7fef0d 100644 --- a/sound/usb/line6/podhd.c +++ b/sound/usb/line6/podhd.c @@ -293,12 +293,10 @@ static void podhd_set_monitor_level(struct usb_line6_podhd *podhd, int value) }; unsigned char *buf; - buf = kmalloc(sizeof(msg), GFP_KERNEL); + buf = kmemdup(msg, sizeof(msg), GFP_KERNEL); if (!buf) return; - memcpy(buf, msg, sizeof(msg)); - if (value < 0) value = 0;
Use kmemdup rather than duplicating its implementation. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- sound/usb/line6/podhd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)