| Message ID | 20200727145840.25142-3-Vishnuvardhanrao.Ravulapati@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] ASoC: amd: Renaming snd-soc-card structure and fields. | expand |
On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote: > changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, > This flag which was previously set as SND_SOC_RT5682 > used to build rt5682 codec driver but by changing into > SND_SOC_RT5682_I2C is preventing to build rt5682 codec > driver and machine driver fails to probe.So Reverting the changes. The split between I2C and SoundWire means you have to choose the I2C or SDW mode. Selecting the common part looks very strange. see Intel machine drviers: Kconfig: select SND_SOC_RT5682_I2C Kconfig: select SND_SOC_RT5682_I2C Kconfig: select SND_SOC_RT5682_I2C Kconfig: select SND_SOC_RT5682_SDW > > Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com> > --- > sound/soc/amd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig > index e37cf72f2bab..77ffdb41bee5 100644 > --- a/sound/soc/amd/Kconfig > +++ b/sound/soc/amd/Kconfig > @@ -29,7 +29,7 @@ config SND_SOC_AMD_ACP3x > > config SND_SOC_AMD_RV_RT5682_MACH > tristate "AMD RV support for RT5682" > - select SND_SOC_RT5682_I2C > + select SND_SOC_RT5682 > select SND_SOC_MAX98357A > select SND_SOC_CROS_EC_CODEC > select I2C_CROS_EC_TUNNEL >
On Mon, Jul 27, 2020 at 10:31:24AM -0500, Pierre-Louis Bossart wrote: > On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote: > > changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, > > This flag which was previously set as SND_SOC_RT5682 > > used to build rt5682 codec driver but by changing into > > SND_SOC_RT5682_I2C is preventing to build rt5682 codec > > driver and machine driver fails to probe.So Reverting the changes. > The split between I2C and SoundWire means you have to choose the I2C or SDW > mode. Selecting the common part looks very strange. Right, and I can't understand the commit message at all. What's the actual issue here and how could this fix it - in what situation wouldn't you need one of the bus modules?
[AMD Official Use Only - Internal Distribution Only] So Actually for rt5682 codec Now in 5.8 there are three flags : SND_SOC_RT5682 SND_SOC_RT5682_I2C SND_SOC_RT5682_SDW But till 5.7.8 we have SND_SOC_RT5682 SND_SOC_RT5682_SDW So in our design we were using SND_SOC_RT5682 which build snd_soc_rt5682.ko Creates the respective codec_dais as defined in that .ko If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links. As there are three flags defined in codecs, I expect that previous one which we were using(SND_SOC_RT5682) is not a wrong flag and I expect to use SND_SOC_RT5682 as it is still available. Thanks, Vishnu -----Original Message----- From: Mark Brown <broonie@kernel.org> Sent: Monday, July 27, 2020 9:40 PM To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@amd.com>; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-devel@alsa-project.org>; Arnd Bergmann <arnd@arndb.de>; open list <linux-kernel@vger.kernel.org>; YueHaibing <yuehaibing@huawei.com>; Takashi Iwai <tiwai@suse.com>; Enric Balletbo i Serra <enric.balletbo@collabora.com>; Liam Girdwood <lgirdwood@gmail.com>; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Agrawal, Akshu <Akshu.Agrawal@amd.com> Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682 On Mon, Jul 27, 2020 at 10:31:24AM -0500, Pierre-Louis Bossart wrote: > On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote: > > changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, This flag > > which was previously set as SND_SOC_RT5682 used to build rt5682 > > codec driver but by changing into SND_SOC_RT5682_I2C is preventing > > to build rt5682 codec driver and machine driver fails to probe.So > > Reverting the changes. > The split between I2C and SoundWire means you have to choose the I2C > or SDW mode. Selecting the common part looks very strange. Right, and I can't understand the commit message at all. What's the actual issue here and how could this fix it - in what situation wouldn't you need one of the bus modules?
On Tue, Jul 28, 2020 at 06:59:50AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > So Actually for rt5682 codec Now in 5.8 there are three flags : > SND_SOC_RT5682 > SND_SOC_RT5682_I2C > SND_SOC_RT5682_SDW > But till 5.7.8 we have > SND_SOC_RT5682 > SND_SOC_RT5682_SDW > So in our design we were using SND_SOC_RT5682 which build snd_soc_rt5682.ko > Creates the respective codec_dais as defined in that .ko > If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links. Could you be more specific about the way in which "it is not creating the expected codec_dai links" please? What are you expecting to happen and what happens instead? Do you see any error messages for example? > As there are three flags defined in codecs, I expect that previous one which we were using(SND_SOC_RT5682) is not a wrong flag and I expect to use > SND_SOC_RT5682 as it is still available. Given that the core module does not register with any bus it is difficult to see how that could possibly work - the core module doesn't contain a driver at all. Have you tested this change?
On 7/28/20 7:07 AM, Mark Brown wrote: > On Tue, Jul 28, 2020 at 06:59:50AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > >> So Actually for rt5682 codec Now in 5.8 there are three flags : >> SND_SOC_RT5682 >> SND_SOC_RT5682_I2C >> SND_SOC_RT5682_SDW > >> But till 5.7.8 we have >> SND_SOC_RT5682 >> SND_SOC_RT5682_SDW > >> So in our design we were using SND_SOC_RT5682 which build snd_soc_rt5682.ko >> Creates the respective codec_dais as defined in that .ko > >> If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links. > > Could you be more specific about the way in which "it is not creating > the expected codec_dai links" please? What are you expecting to happen > and what happens instead? Do you see any error messages for example? > >> As there are three flags defined in codecs, I expect that previous one which we were using(SND_SOC_RT5682) is not a wrong flag and I expect to use >> SND_SOC_RT5682 as it is still available. > > Given that the core module does not register with any bus it is > difficult to see how that could possibly work - the core module doesn't > contain a driver at all. Have you tested this change? I share Mark's point. Have you tested this change on top of Mark's tree, or only on top of the stable kernel?
[AMD Official Use Only - Internal Distribution Only] -----Original Message----- From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Sent: Tuesday, July 28, 2020 5:48 PM To: Mark Brown <broonie@kernel.org>; RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@amd.com> Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-devel@alsa-project.org>; Arnd Bergmann <arnd@arndb.de>; Liam Girdwood <lgirdwood@gmail.com>; open list <linux-kernel@vger.kernel.org>; YueHaibing <yuehaibing@huawei.com>; Takashi Iwai <tiwai@suse.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Enric Balletbo i Serra <enric.balletbo@collabora.com>; Agrawal, Akshu <Akshu.Agrawal@amd.com> Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682 On 7/28/20 7:07 AM, Mark Brown wrote: > On Tue, Jul 28, 2020 at 06:59:50AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > >> So Actually for rt5682 codec Now in 5.8 there are three flags : >> SND_SOC_RT5682 >> SND_SOC_RT5682_I2C >> SND_SOC_RT5682_SDW > >> But till 5.7.8 we have >> SND_SOC_RT5682 >> SND_SOC_RT5682_SDW > >> So in our design we were using SND_SOC_RT5682 which build >> snd_soc_rt5682.ko Creates the respective codec_dais as defined in >> that .ko > >> If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links. > > Could you be more specific about the way in which "it is not creating > the expected codec_dai links" please? What are you expecting to > happen and what happens instead? Do you see any error messages for example? > >> As there are three flags defined in codecs, I expect that previous >> one which we were using(SND_SOC_RT5682) is not a wrong flag and I >> expect to use >> SND_SOC_RT5682 as it is still available. > > Given that the core module does not register with any bus it is > difficult to see how that could possibly work - the core module > doesn't contain a driver at all. Have you tested this change? I share Mark's point. Have you tested this change on top of Mark's tree, or only on top of the stable kernel? Ok. I will drop that patch and send the other series. Thanks,
On Tue, Jul 28, 2020 at 03:24:42PM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > [AMD Official Use Only - Internal Distribution Only] > > -----Original Message----- > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Sent: Tuesday, July 28, 2020 5:48 PM I'm not seeing any new text in here? > To: Mark Brown <broonie@kernel.org>; RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@amd.com> > Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-devel@alsa-project.org>; Arnd Bergmann <arnd@arndb.de>; Liam Girdwood <lgirdwood@gmail.com>; open list <linux-kernel@vger.kernel.org>; YueHaibing <yuehaibing@huawei.com>; Takashi Iwai <tiwai@suse.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Enric Balletbo i Serra <enric.balletbo@collabora.com>; Agrawal, Akshu <Akshu.Agrawal@amd.com> > Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682 > > > > On 7/28/20 7:07 AM, Mark Brown wrote: > > On Tue, Jul 28, 2020 at 06:59:50AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > > > >> So Actually for rt5682 codec Now in 5.8 there are three flags : > >> SND_SOC_RT5682 > >> SND_SOC_RT5682_I2C > >> SND_SOC_RT5682_SDW > > > >> But till 5.7.8 we have > >> SND_SOC_RT5682 > >> SND_SOC_RT5682_SDW > > > >> So in our design we were using SND_SOC_RT5682 which build > >> snd_soc_rt5682.ko Creates the respective codec_dais as defined in > >> that .ko > > > >> If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links. > > > > Could you be more specific about the way in which "it is not creating > > the expected codec_dai links" please? What are you expecting to > > happen and what happens instead? Do you see any error messages for example? > > > >> As there are three flags defined in codecs, I expect that previous > >> one which we were using(SND_SOC_RT5682) is not a wrong flag and I > >> expect to use > >> SND_SOC_RT5682 as it is still available. > > > > Given that the core module does not register with any bus it is > > difficult to see how that could possibly work - the core module > > doesn't contain a driver at all. Have you tested this change? > > I share Mark's point. Have you tested this change on top of Mark's tree, or only on top of the stable kernel? > Ok. I will drop that patch and send the other series. > > Thanks, >
I will drop this patch series and will send new series. Thanks, -----Original Message----- From: Mark Brown <broonie@kernel.org> Sent: Tuesday, July 28, 2020 9:06 PM To: RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@amd.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-devel@alsa-project.org>; Arnd Bergmann <arnd@arndb.de>; Liam Girdwood <lgirdwood@gmail.com>; open list <linux-kernel@vger.kernel.org>; YueHaibing <yuehaibing@huawei.com>; Takashi Iwai <tiwai@suse.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Enric Balletbo i Serra <enric.balletbo@collabora.com>; Agrawal, Akshu <Akshu.Agrawal@amd.com> Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682 On Tue, Jul 28, 2020 at 03:24:42PM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > [AMD Official Use Only - Internal Distribution Only] > > -----Original Message----- > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Sent: Tuesday, July 28, 2020 5:48 PM I'm not seeing any new text in here? > To: Mark Brown <broonie@kernel.org>; RAVULAPATI, VISHNU VARDHAN RAO > <Vishnuvardhanrao.Ravulapati@amd.com> > Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... > <alsa-devel@alsa-project.org>; Arnd Bergmann <arnd@arndb.de>; Liam > Girdwood <lgirdwood@gmail.com>; open list > <linux-kernel@vger.kernel.org>; YueHaibing <yuehaibing@huawei.com>; > Takashi Iwai <tiwai@suse.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Mukunda, Vijendar > <Vijendar.Mukunda@amd.com>; Enric Balletbo i Serra > <enric.balletbo@collabora.com>; Agrawal, Akshu <Akshu.Agrawal@amd.com> > Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build > rt5682 > > > > On 7/28/20 7:07 AM, Mark Brown wrote: > > On Tue, Jul 28, 2020 at 06:59:50AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > > > >> So Actually for rt5682 codec Now in 5.8 there are three flags : > >> SND_SOC_RT5682 > >> SND_SOC_RT5682_I2C > >> SND_SOC_RT5682_SDW > > > >> But till 5.7.8 we have > >> SND_SOC_RT5682 > >> SND_SOC_RT5682_SDW > > > >> So in our design we were using SND_SOC_RT5682 which build > >> snd_soc_rt5682.ko Creates the respective codec_dais as defined in > >> that .ko > > > >> If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links. > > > > Could you be more specific about the way in which "it is not > > creating the expected codec_dai links" please? What are you > > expecting to happen and what happens instead? Do you see any error messages for example? > > > >> As there are three flags defined in codecs, I expect that previous > >> one which we were using(SND_SOC_RT5682) is not a wrong flag and I > >> expect to use > >> SND_SOC_RT5682 as it is still available. > > > > Given that the core module does not register with any bus it is > > difficult to see how that could possibly work - the core module > > doesn't contain a driver at all. Have you tested this change? > > I share Mark's point. Have you tested this change on top of Mark's tree, or only on top of the stable kernel? > Ok. I will drop that patch and send the other series. > > Thanks, >
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index e37cf72f2bab..77ffdb41bee5 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -29,7 +29,7 @@ config SND_SOC_AMD_ACP3x config SND_SOC_AMD_RV_RT5682_MACH tristate "AMD RV support for RT5682" - select SND_SOC_RT5682_I2C + select SND_SOC_RT5682 select SND_SOC_MAX98357A select SND_SOC_CROS_EC_CODEC select I2C_CROS_EC_TUNNEL
changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because, This flag which was previously set as SND_SOC_RT5682 used to build rt5682 codec driver but by changing into SND_SOC_RT5682_I2C is preventing to build rt5682 codec driver and machine driver fails to probe.So Reverting the changes. Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com> --- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)