| Message ID | 20200818024120.20721-10-yung-chuan.liao@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: intel: add multi-link support | expand |
On 18-08-20, 10:41, Bard Liao wrote: > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > Detect cases where the clock is assumed to be stopped but the IP is > not in the relevant state, and add a dynamic debug trace. you meant a debug print..and it looks like error print below (also in title). > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > --- > drivers/soundwire/intel.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 7c63581270fd..b82d02af3c4f 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1964,6 +1964,11 @@ static int intel_resume_runtime(struct device *dev) > } > } > } else if (!clock_stop_quirks) { > + > + clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns); > + if (!clock_stop0) > + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); > + > ret = intel_init(sdw); > if (ret) { > dev_err(dev, "%s failed: %d", __func__, ret); > -- > 2.17.1
On 8/26/20 4:48 AM, Vinod Koul wrote: > On 18-08-20, 10:41, Bard Liao wrote: >> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> >> Detect cases where the clock is assumed to be stopped but the IP is >> not in the relevant state, and add a dynamic debug trace. > > you meant a debug print..and it looks like error print below (also in title). I don't understand the comment. Is the 'trace' confusing and are you asking to e.g. change the commit message to 'add dynamic debug log'? > >> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> >> --- >> drivers/soundwire/intel.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c >> index 7c63581270fd..b82d02af3c4f 100644 >> --- a/drivers/soundwire/intel.c >> +++ b/drivers/soundwire/intel.c >> @@ -1964,6 +1964,11 @@ static int intel_resume_runtime(struct device *dev) >> } >> } >> } else if (!clock_stop_quirks) { >> + >> + clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns); >> + if (!clock_stop0) >> + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); >> + >> ret = intel_init(sdw); >> if (ret) { >> dev_err(dev, "%s failed: %d", __func__, ret); >> -- >> 2.17.1 >
On 26-08-20, 09:38, Pierre-Louis Bossart wrote: > > > On 8/26/20 4:48 AM, Vinod Koul wrote: > > On 18-08-20, 10:41, Bard Liao wrote: > > > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > > > > > Detect cases where the clock is assumed to be stopped but the IP is > > > not in the relevant state, and add a dynamic debug trace. > > > > you meant a debug print..and it looks like error print below (also in title). > > I don't understand the comment. Is the 'trace' confusing and are you asking > to e.g. change the commit message to 'add dynamic debug log'? Question is what is dynamic about this?
>>>> Detect cases where the clock is assumed to be stopped but the IP is >>>> not in the relevant state, and add a dynamic debug trace. >>> >>> you meant a debug print..and it looks like error print below (also in title). >> >> I don't understand the comment. Is the 'trace' confusing and are you asking >> to e.g. change the commit message to 'add dynamic debug log'? > > Question is what is dynamic about this? dev_dbg() is part of the kernel dynamic debug capability... https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html Not sure what you are asking here?
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 7c63581270fd..b82d02af3c4f 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1964,6 +1964,11 @@ static int intel_resume_runtime(struct device *dev) } } } else if (!clock_stop_quirks) { + + clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns); + if (!clock_stop0) + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); + ret = intel_init(sdw); if (ret) { dev_err(dev, "%s failed: %d", __func__, ret);