| Message ID | 20201113055400.11242-2-oder_chiou@realtek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 33ee67b47ba09fc30840668c9ccec5ad18c94de0 |
| Headers | show |
| Series | [1/2] ASoC: rt5682: Add a new property for the DMIC clock driving | expand |
Couple of typos you may want to fix On 11/12/20 11:54 PM, Oder Chiou wrote: > The patch adds a new property to the drice tree for the DMIC clcok driving. device? > > Signed-off-by: Oder Chiou <oder_chiou@realtek.com> > --- > Documentation/devicetree/bindings/sound/rt5682.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt > index 707fa98d1310..9c5fadb6ac82 100644 > --- a/Documentation/devicetree/bindings/sound/rt5682.txt > +++ b/Documentation/devicetree/bindings/sound/rt5682.txt > @@ -44,6 +44,8 @@ Optional properties: > - realtek,dmic-delay-ms : Set the delay time (ms) for the requirement of > the particular DMIC. > > +- realtek,dmic-clk-driving-high : Set the high drving of the DMIC clock out. driving? I must admit I actually don't understand what 'dmic-clk-driving-high' means, a clock is by definition dual-phase and we use both rising and falling edges for the mics. Or driving high when idle? > + > Pins on the device (for linking into audio routes) for RT5682: > > * DMIC L1 >
> > diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt > > b/Documentation/devicetree/bindings/sound/rt5682.txt > > index 707fa98d1310..9c5fadb6ac82 100644 > > --- a/Documentation/devicetree/bindings/sound/rt5682.txt > > +++ b/Documentation/devicetree/bindings/sound/rt5682.txt > > @@ -44,6 +44,8 @@ Optional properties: > > - realtek,dmic-delay-ms : Set the delay time (ms) for the requirement of > > the particular DMIC. > > > > +- realtek,dmic-clk-driving-high : Set the high drving of the DMIC clock out. > > driving? > > I must admit I actually don't understand what 'dmic-clk-driving-high' > means, a clock is by definition dual-phase and we use both rising and falling > edges for the mics. > > Or driving high when idle? That reduces the rising time and falling time while the clock is output, and not driving high always when idle, thanks.
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt index 707fa98d1310..9c5fadb6ac82 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -44,6 +44,8 @@ Optional properties: - realtek,dmic-delay-ms : Set the delay time (ms) for the requirement of the particular DMIC. +- realtek,dmic-clk-driving-high : Set the high drving of the DMIC clock out. + Pins on the device (for linking into audio routes) for RT5682: * DMIC L1
The patch adds a new property to the drice tree for the DMIC clcok driving. Signed-off-by: Oder Chiou <oder_chiou@realtek.com> --- Documentation/devicetree/bindings/sound/rt5682.txt | 2 ++ 1 file changed, 2 insertions(+)