diff mbox series

ASoC: rt5682: remove LDO2 power supply widget

Message ID 20210119091158.12988-1-shumingf@realtek.com (mailing list archive)
State New, archived
Headers show
Series ASoC: rt5682: remove LDO2 power supply widget | expand

Commit Message

Shuming [θŒƒζ›ΈιŠ˜] Jan. 19, 2021, 9:11 a.m. UTC 
From: Shuming Fan <shumingf@realtek.com>

The application circuit shall provide MICVDD power.
Hence, the codec driver doesn't need to enable LDO2.
This patch also reduces power consumption while the recording from the headset.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
 sound/soc/codecs/rt5682.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Mark Brown Jan. 19, 2021, 12:46 p.m. UTC | #1 
On Tue, Jan 19, 2021 at 05:11:58PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> The application circuit shall provide MICVDD power.
> Hence, the codec driver doesn't need to enable LDO2.
> This patch also reduces power consumption while the recording from the headset.

This sounds very board specific - shouldn't this be something configured
by the platform?  Having a default that doesn't use the LDO is fine but
some platforms could reasonably use the LDO that's there.
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 42ad5bea86b5..81a4b115b538 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -1630,8 +1630,6 @@  static const struct snd_kcontrol_new rt5682_adcdat_pin_ctrl =
 	SOC_DAPM_ENUM("ADCDAT", rt5682_adcdat_pin_enum);
 
 static const struct snd_soc_dapm_widget rt5682_dapm_widgets[] = {
-	SND_SOC_DAPM_SUPPLY("LDO2", RT5682_PWR_ANLG_3, RT5682_PWR_LDO2_BIT,
-		0, NULL, 0),
 	SND_SOC_DAPM_SUPPLY("PLL1", RT5682_PWR_ANLG_3, RT5682_PWR_PLL_BIT,
 		0, NULL, 0),
 	SND_SOC_DAPM_SUPPLY("PLL2B", RT5682_PWR_ANLG_3, RT5682_PWR_PLL2B_BIT,
@@ -1854,8 +1852,6 @@  static const struct snd_soc_dapm_route rt5682_dapm_routes[] = {
 
 	{"CLKDET SYS", NULL, "CLKDET"},
 
-	{"IN1P", NULL, "LDO2"},
-
 	{"BST1 CBJ", NULL, "IN1P"},
 
 	{"RECMIX1L", "CBJ Switch", "BST1 CBJ"},