diff mbox series

[-next] ASoC: rt1019: make symbol 'rt1019_i2c_driver' static

Message ID 20210319094102.4185096-1-weiyongjun1@huawei.com (mailing list archive)
State Accepted
Commit e6d8af6687fa7730885d5c8d8f62e75e8dff29f0
Headers show
Series [-next] ASoC: rt1019: make symbol 'rt1019_i2c_driver' static | expand

Commit Message

Wei Yongjun March 19, 2021, 9:41 a.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

The sparse tool complains as follows:

sound/soc/codecs/rt1019.c:927:19: warning:
 symbol 'rt1019_i2c_driver' was not declared. Should it be static?

This symbol is not used outside of rt1019.c, so this
commit marks it static.

Fixes: 7ec79d3850d0 ("ASoC: rt1019: add rt1019 amplifier driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 sound/soc/codecs/rt1019.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown March 19, 2021, 4:37 p.m. UTC | #1 
On Fri, 19 Mar 2021 09:41:02 +0000, 'w00385741 wrote:
> The sparse tool complains as follows:
> 
> sound/soc/codecs/rt1019.c:927:19: warning:
>  symbol 'rt1019_i2c_driver' was not declared. Should it be static?
> 
> This symbol is not used outside of rt1019.c, so this
> commit marks it static.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt1019: make symbol 'rt1019_i2c_driver' static
      commit: e6d8af6687fa7730885d5c8d8f62e75e8dff29f0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt1019.c b/sound/soc/codecs/rt1019.c
index fb275686a00f..5138f028d9f2 100644
--- a/sound/soc/codecs/rt1019.c
+++ b/sound/soc/codecs/rt1019.c
@@ -924,7 +924,7 @@  static int rt1019_i2c_probe(struct i2c_client *i2c,
 		&soc_component_dev_rt1019, rt1019_dai, ARRAY_SIZE(rt1019_dai));
 }
 
-struct i2c_driver rt1019_i2c_driver = {
+static struct i2c_driver rt1019_i2c_driver = {
 	.driver = {
 		.name = "rt1019",
 		.of_match_table = of_match_ptr(rt1019_of_match),