| Message ID | 20210511101051.17726-1-ckeepax@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 634a4be0f9d16428779d60bb40fd852f888f0a34 |
| Headers | show |
| Series | [1/3] ASoC: cs35l36: Remove unneeded variable initialisation | expand |
On 5/11/21 5:10 AM, Charles Keepax wrote: > Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, I rechecked with this patchset applied on top of the previous one, there's only one warning left: sound/soc/codecs/cs42l56.c:1308:6: style: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] ret = devm_snd_soc_register_component(&i2c_client->dev, ^ sound/soc/codecs/cs42l56.c:1247:6: note: ret is assigned ret = regmap_read(cs42l56->regmap, CS42L56_CHIP_ID_1, ®); ^ sound/soc/codecs/cs42l56.c:1308:6: note: ret is overwritten ret = devm_snd_soc_register_component(&i2c_client->dev, ^ > --- > sound/soc/codecs/cs35l36.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c > index a038bcec2d17c..db5472b10465b 100644 > --- a/sound/soc/codecs/cs35l36.c > +++ b/sound/soc/codecs/cs35l36.c > @@ -1156,7 +1156,7 @@ static int cs35l36_component_probe(struct snd_soc_component *component) > { > struct cs35l36_private *cs35l36 = > snd_soc_component_get_drvdata(component); > - int ret = 0; > + int ret; > > if ((cs35l36->rev_id == CS35L36_REV_A0) && cs35l36->pdata.dcm_mode) { > regmap_update_bits(cs35l36->regmap, CS35L36_BSTCVRT_DCM_CTRL, >
On Tue, 11 May 2021 11:10:49 +0100, Charles Keepax wrote:
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/3] ASoC: cs35l36: Remove unneeded variable initialisation
commit: 634a4be0f9d16428779d60bb40fd852f888f0a34
[2/3] ASoC: cs4265: Minor tidy up of error paths
commit: fd4e6baa6256b9c5cb6d8d6a020093ee9aee0372
[3/3] ASoC: cs42l52: Minor tidy up of error paths
commit: 4ac9b48adf4d561d0e33419d548278f205dd70b5
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index a038bcec2d17c..db5472b10465b 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -1156,7 +1156,7 @@ static int cs35l36_component_probe(struct snd_soc_component *component) { struct cs35l36_private *cs35l36 = snd_soc_component_get_drvdata(component); - int ret = 0; + int ret; if ((cs35l36->rev_id == CS35L36_REV_A0) && cs35l36->pdata.dcm_mode) { regmap_update_bits(cs35l36->regmap, CS35L36_BSTCVRT_DCM_CTRL,
Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- sound/soc/codecs/cs35l36.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)