| Message ID | 20210511190306.2418917-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9b7493468fa7eeef2e86b8c646c0535c00eed3e2 |
| Headers | show |
| Series | Revert "ASoC: q6dsp: q6afe: remove unneeded dead-store initialization" | expand |
On Tue, May 11, 2021 at 12:03:06PM -0700, Nathan Chancellor wrote: > This reverts commit 5f1b95d08de712327e452d082a50fded435ec884. > > The warnings that commit 5f1b95d08de7 ("ASoC: q6dsp: q6afe: remove > unneeded dead-store initialization") was trying to fix were already Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Tue, 11 May 2021 12:03:06 -0700, Nathan Chancellor wrote: > This reverts commit 5f1b95d08de712327e452d082a50fded435ec884. > > The warnings that commit 5f1b95d08de7 ("ASoC: q6dsp: q6afe: remove > unneeded dead-store initialization") was trying to fix were already > fixed in commit 12900bacb4f3 ("ASoC: qcom: q6afe: remove useless > assignments"). With both commits in the tree, port_id is uninitialized, > as pointed out by clang: > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] Revert "ASoC: q6dsp: q6afe: remove unneeded dead-store initialization" commit: 9b7493468fa7eeef2e86b8c646c0535c00eed3e2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index c5c1818a6f75..729d27da0447 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -1183,7 +1183,7 @@ int q6afe_port_stop(struct q6afe_port *port) struct afe_port_cmd_device_stop *stop; struct q6afe *afe = port->afe; struct apr_pkt *pkt; - int port_id; + int port_id = port->id; int ret = 0; int index, pkt_size; void *p;
This reverts commit 5f1b95d08de712327e452d082a50fded435ec884. The warnings that commit 5f1b95d08de7 ("ASoC: q6dsp: q6afe: remove unneeded dead-store initialization") was trying to fix were already fixed in commit 12900bacb4f3 ("ASoC: qcom: q6afe: remove useless assignments"). With both commits in the tree, port_id is uninitialized, as pointed out by clang: sound/soc/qcom/qdsp6/q6afe.c:1213:18: warning: variable 'port_id' is uninitialized when used here [-Wuninitialized] stop->port_id = port_id; ^~~~~~~ sound/soc/qcom/qdsp6/q6afe.c:1186:13: note: initialize the variable 'port_id' to silence this warning int port_id; ^ = 0 1 warning generated. Bring back the initialization so that everything works as intended. Fixes: 5f1b95d08de7 ("ASoC: q6dsp: q6afe: remove unneeded dead-store initialization") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- sound/soc/qcom/qdsp6/q6afe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 4ac9b48adf4d561d0e33419d548278f205dd70b5