[next] ALSA: hda/ca0132: Make a const array static, makes object smaller

Commit Message

Colin King May 26, 2021, 4:06 p.m. UTC

From: Colin Ian King <[e-mail]>

Don't populate the const array dsp_dma_stream_ids the stack but instead
make it static. Makes the object code smaller by 21 bytes.

Before:
   text    data     bss     dec     hex filename
 189012   70376     192  259580   3f5fc ./sound/pci/hda/patch_ca0132.o

After:
   text    data     bss     dec     hex filename
 188927   70440     192  259559   3f5e7 ./sound/pci/hda/patch_ca0132.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King <[e-mail]>
---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai May 27, 2021, 6:26 a.m. UTC | #1

On Wed, 26 May 2021 18:06:16 +0200,
Colin King wrote:
> 
> From: Colin Ian King <[e-mail]>
> 
> Don't populate the const array dsp_dma_stream_ids the stack but instead
> make it static. Makes the object code smaller by 21 bytes.
> 
> Before:
>    text    data     bss     dec     hex filename
>  189012   70376     192  259580   3f5fc ./sound/pci/hda/patch_ca0132.o
> 
> After:
>    text    data     bss     dec     hex filename
>  188927   70440     192  259559   3f5e7 ./sound/pci/hda/patch_ca0132.o
> 
> (gcc version 10.3.0)
> 
> Signed-off-by: Colin Ian King <[e-mail]>

Thanks, applied.


Takashi

Patch

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 49b4fdd2feab..b66e7bdbf483 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -7598,7 +7598,7 @@  static void ca0132_alt_free_active_dma_channels(struct hda_codec *codec)
  */
 static void ca0132_alt_start_dsp_audio_streams(struct hda_codec *codec)
 {
-	const unsigned int dsp_dma_stream_ids[] = { 0x0c, 0x03, 0x04 };
+	static const unsigned int dsp_dma_stream_ids[] = { 0x0c, 0x03, 0x04 };
 	struct ca0132_spec *spec = codec->spec;
 	unsigned int i, tmp;