diff mbox series

ASoC: rk817: fix a warning in rk817_probe()

Message ID 20210601214424.23432-1-macroalpha82@gmail.com (mailing list archive)
State Accepted
Commit ef7570b67541d8b938df1e45f56e54be70bf1360
Headers show
Series ASoC: rk817: fix a warning in rk817_probe() | expand

Commit Message

Chris Morgan June 1, 2021, 9:44 p.m. UTC 
From: Chris Morgan <macromorgan@hotmail.com>

The return value of snd_soc_component_write() is stored but not
evaluated and this results in a warning when W=1 is set. Stop storing
the return value to be consistent with all other calls of
snd_soc_component_write() and to remove the warning.

Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 sound/soc/codecs/rk817_codec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Lee Jones June 2, 2021, 7:02 a.m. UTC | #1 
On Tue, 01 Jun 2021, Chris Morgan wrote:

> From: Chris Morgan <macromorgan@hotmail.com>
> 
> The return value of snd_soc_component_write() is stored but not
> evaluated and this results in a warning when W=1 is set. Stop storing
> the return value to be consistent with all other calls of
> snd_soc_component_write() and to remove the warning.
> 
> Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  sound/soc/codecs/rk817_codec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

Mark, I'll send out another PR shortly.
diff mbox series

Patch

diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
index 17e672b85ee5..fd3a5ba034a9 100644
--- a/sound/soc/codecs/rk817_codec.c
+++ b/sound/soc/codecs/rk817_codec.c
@@ -415,12 +415,11 @@  static int rk817_probe(struct snd_soc_component *component)
 {
 	struct rk817_codec_priv *rk817 = snd_soc_component_get_drvdata(component);
 	struct rk808 *rk808 = dev_get_drvdata(component->dev->parent);
-	int ret;
 
 	snd_soc_component_init_regmap(component, rk808->regmap);
 	rk817->component = component;
 
-	ret = snd_soc_component_write(component, RK817_CODEC_DTOP_LPT_SRST, 0x40);
+	snd_soc_component_write(component, RK817_CODEC_DTOP_LPT_SRST, 0x40);
 
 	rk817_init(component);