From patchwork Mon Aug 2 19:03:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 12414631 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D50C4338F for ; Mon, 2 Aug 2021 19:06:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2CD861051 for ; Mon, 2 Aug 2021 19:06:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C2CD861051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2C1D81728; Mon, 2 Aug 2021 21:05:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2C1D81728 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627931198; bh=hkaaGUj6LD92fLf2eKN3+HpYv9SsLiKngPrIRD0KtlM=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=kqyPti0j0VtJPErpHKWsN+cGypb00j1grr+3mj8yO+eJtfhQMPMOTxLv9EruEuuPz o0dxg1TzRgr8IbG1mp5NYU0rZU8Z8ifiWOJqzVOfS/2p0Mc8zw0VR35TLIKNqVqwsr HugawT6gxh7m6xNbp/Md78kHXEYRruOJzRl4Swo0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A8B58F801F7; Mon, 2 Aug 2021 21:05:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E1974F80268; Mon, 2 Aug 2021 21:05:45 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1A6D8F800BF for ; Mon, 2 Aug 2021 21:05:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1A6D8F800BF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BZpOPWEX" Received: by mail.kernel.org (Postfix) with ESMTPSA id 430A3610FE; Mon, 2 Aug 2021 19:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627931134; bh=hkaaGUj6LD92fLf2eKN3+HpYv9SsLiKngPrIRD0KtlM=; h=From:To:Cc:Subject:Date:From; b=BZpOPWEXpoS4JqwJKBQ3WW6TKoUs/O6B6fl0X2XqIDOPhRAIczQ2sRhOjDSi+TUpZ UJwoRdWOn4u58xoJdyE6wk57hHHSuFCrZ9Qwd0RvcD75fcBO4KixsiDiBKR4PGNRoy d8ts/TqUVVkHMaPyKnZRDXZkj7ajNFBo4S4tm+Ls63YwceeGSJ1dLT5c+6CZqD5lRq K+E01boePl76Fie14FgcUnD12fGdZ9LKDqCuX2tHSjA0s9OlwlYp3WHfML1h2BcbY3 6x/elMge61OQoubmsLtlaiTCfKyv17WzALhkWVY+Mtg5MjBlUGMYs/tP0UJvVYfNA5 3cVxMw4iOSCDA== From: Nathan Chancellor To: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown Subject: [PATCH] ASoC: Intel: boards: Fix CONFIG_SND_SOC_SDW_MOCKUP select Date: Mon, 2 Aug 2021 12:03:52 -0700 Message-Id: <20210802190351.3201677-1-nathan@kernel.org> X-Mailer: git-send-email 2.32.0.264.g75ae10bc75 MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Nathan Chancellor , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" When CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH is enabled without CONFIG_EXPERT, there is a Kconfig warning about unmet dependencies: WARNING: unmet direct dependencies detected for SND_SOC_SDW_MOCKUP Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && EXPERT [=n] && SOUNDWIRE [=y] Selected by [y]: - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && ... Selecting a symbol does not account for dependencies so if symbol A selects symbol B which depends on symbol C, symbol B or its select of symbol A should depend on symbol C as well. Make the CONFIG_SND_SOC_SDW_MOCKUP select in CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH depend on CONFIG_EXPERT as the help text for CONFIG_SND_SOC_SDW_MOCKUP indicates it is intended to be a development option. Fixes: 0ccac3bcf356 ("ASoC: Intel: boards: sof_sdw: add SoundWire mockup codecs for tests") Signed-off-by: Nathan Chancellor --- An alternative here is if CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH wants to unconditionally select CONFIG_SND_SOC_SDW_MOCKUP, the "depends on EXPERT" can be moved to the prompt (tristate "..." if EXPERT). I am happy to send a new patch if that is what is desired. sound/soc/intel/boards/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 170c0d7460fc4aa522995ae4096b5a442f50a1fc diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index 046955bf717c..8284c46d7435 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -602,7 +602,7 @@ config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH select SND_SOC_DMIC select SND_SOC_INTEL_HDA_DSP_COMMON select SND_SOC_INTEL_SOF_MAXIM_COMMON - select SND_SOC_SDW_MOCKUP + select SND_SOC_SDW_MOCKUP if EXPERT help Add support for Intel SoundWire-based platforms connected to MAX98373, RT700, RT711, RT1308 and RT715